Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecobee humidifier #16139

Merged
merged 7 commits into from
Apr 13, 2021
Merged

Add ecobee humidifier #16139

merged 7 commits into from
Apr 13, 2021

Conversation

treylok
Copy link
Contributor

@treylok treylok commented Jan 10, 2021

Proposed change

Document ability to set the humidifier mode of an ecobee thermostat with a humidifier attached.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: Add Ecobee humidifier core#45003
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 10, 2021
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Jan 10, 2021
@probot-home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.
(message by DocsTargetBranch)

@frenck frenck added this to To Do in New documentation via automation Jan 10, 2021
@frenck frenck moved this from To Do to In Progress in New documentation Jan 10, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to be targeting the next branch, as it relies on a code change in the Home Assistant code base (and thus a next release).

Please change the target of this PR to the next branch and git rebase the PR if needed.

Thanks 👍

@treylok treylok changed the base branch from current to next January 10, 2021 22:05
@frenck
Copy link
Member

frenck commented Jan 25, 2021

There are unrelated commits in this PR, you still need to rebase it onto the next branch @treylok 👍

@treylok
Copy link
Contributor Author

treylok commented Jan 25, 2021

Sorry, not sure what I did. Hopefully this is correct.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that did the trick @treylok 👍

2 small suggestions and the docs are ready to go 👍

source/_integrations/ecobee.markdown Outdated Show resolved Hide resolved
source/_integrations/ecobee.markdown Outdated Show resolved Hide resolved
New documentation automation moved this from In Progress to Awaiting Parent PR Jan 25, 2021
frenck
frenck previously approved these changes Jan 25, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Jan 25, 2021
@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 25, 2021
@klaasnicolaas klaasnicolaas added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch and removed current This PR goes into the current branch labels Jan 26, 2021
@MartinHjelmare MartinHjelmare added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Apr 12, 2021
@project-bot project-bot bot moved this from Awaiting Parent PR to Parent Merged in New documentation Apr 12, 2021
@MartinHjelmare
Copy link
Member

Let's just update the ha_category and ha_platforms front matter.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

New documentation automation moved this from Parent Merged to Awaiting Parent PR Apr 13, 2021
@MartinHjelmare MartinHjelmare changed the title Add ecobee set humidifier mode Add ecobee humidifier Apr 13, 2021
@frenck frenck merged commit 228991a into home-assistant:next Apr 13, 2021
New documentation automation moved this from Awaiting Parent PR to Done Apr 13, 2021
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Apr 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants