-
-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add weather platform to template domain #45031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also according to the dev docs, the condition and temperature forecasts are required. One really nice use case for this template is to use the forecasts and current condition from an existing weather integration and the current temperature from a local temperature sensor.
Thank you for the feedback! I've update the PR description :) |
Since I commented here, I found out that the underlying weather entity requires the integration to implement the humidity method in contrast to the developer documentation. It is now unclear what is the expectation. Thanks for linking this PR to the issue. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
This looks handy for anyone wanting to bring in MQTT sensors and populate the weather domain to use the lovelace card also as I noticed there isnt a MQTT Weather component yet. |
Coverage looks good |
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@koston.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Proposed change
Template domain has many platforms, but not weather until now.
The use case is simple: you have separate sensors for temperature/humidity/etc and you want to combine them into a single entity. To top this use case, you can incorporate the forecast from a nearby location provided by another weather integration.
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: