Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dyson for the new fan entity model #45762

Merged
merged 9 commits into from
Jan 31, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 30, 2021

Proposed change

Update dyson for the new fan entity model

Reviewers: apparently there are two different ways to turn on the fan based on the model. Kindly double check to make sure I didn't introduce a refactoring error.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@bdraco bdraco marked this pull request as draft January 30, 2021 23:38
@bdraco
Copy link
Member Author

bdraco commented Jan 30, 2021

Intended to submit this as a draft as I still need to work on the test, but lost internet in the middle of submit. Apparently create as draft works by submitting the pr and marking it as a draft on the client side.

@bdraco
Copy link
Member Author

bdraco commented Jan 31, 2021

Just needed to be wrapped so it converts the int back to a string

@bdraco bdraco marked this pull request as ready for review January 31, 2021 02:30
homeassistant/components/dyson/fan.py Outdated Show resolved Hide resolved
homeassistant/components/dyson/fan.py Outdated Show resolved Hide resolved
homeassistant/components/dyson/fan.py Show resolved Hide resolved
@bdraco
Copy link
Member Author

bdraco commented Jan 31, 2021

Thanks for the review. Will adjust when I get back home

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MartinHjelmare MartinHjelmare merged commit ea7aa6a into home-assistant:dev Jan 31, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants