Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioharmony from 0.2.6 to 0.2.7 #46075

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

ehendrix23
Copy link
Contributor

Proposed change

Update aioharmony to 0.2.7 to fix not unregistering callback handlers after timeout when sending commands, bump slixmpp to 1.7.0 and aiohttp to 3.7.3.

Release notes: https://github.com/ehendrix23/aioharmony#release-notes
Compare view: ehendrix23/aioharmony@v0.2.6...v0.2.7

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @bramkragten, @bdraco, @mkeesey, mind taking a look at this pull request as its been labeled with an integration (harmony) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Member

bdraco commented Feb 6, 2021

unrelated ci failure
FAILED tests/components/prometheus/test_init.py::test_view[pyloop] - assert '...

I'll restart it

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bdraco
Copy link
Member

bdraco commented Feb 6, 2021

Tested and working as expected 👍

@bdraco bdraco merged commit ee98ea8 into home-assistant:dev Feb 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2021
@ehendrix23 ehendrix23 deleted the Bump_aioharmony_to_0.2.7 branch August 16, 2021 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants