-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for v6 features to philips js integration #46422
Conversation
b293c7b
to
4c9735c
Compare
This is amazing work :D Dreamt of doing this, but never took the time to actually dig into this. Kudos on updating everything. Will test it out and deprecate my custom component afterwards. (Or is there anything that my poor custom component can do, your update here can't? If there is, I'll try to add it later on to the official component) For reference, custom v6 implementation: https://github.com/nstrelow/ha_philips_android_tv (damn so close to 100 stars 🙈 ) |
@nstrelow your have very likely handled many edge cases that i have not encountered. So I would be very happy for you to look it over and comment on behaviour you have been forced to handle. |
My edge case handling was bad and I think some recent commit broke the on/off display for most users. Also I am using the synchronous API and I think it works better with async. Will check your code as soon I am back at my TV, probably in 1-2 weeks. Sorry for that. Maybe somebody else can review and test it out until then :) |
It's still not async. It really should be changed to that i suppose. Would clean it up a bit. |
They are also buggy in that re-muting will unmute
Adjust for saphi
…stant into philips_js_pair
Finally able to test out the integration. IT IS AMAZING. Very great to see paring integrated. What works:
What does not work for my model (2016 model: philips 43pus6401/12):
Will investigate more, if there is a way to trigger that HDMI switch, but it is probably just a limitation of older devices Philips TV System Info {
"notifyChange":"http",
"menulanguage":"English",
"name":"Android TV",
"country":"",
"serialnumber":"",
"softwareversion":"AND1E.0.0.0.1",
"model":"43PUS6401/12",
"deviceid":"57334431",
"nettvversion":"8.1.3",
"epgsource":"one",
"api_version":{
"Major":6,
"Minor":2,
"Patch":0
},
"featuring":{
"jsonfeatures":{
"editfavorites":[
"TVChannels",
"SatChannels"
],
"recordings":[
"List",
"Schedule",
"Manage"
],
"ambilight":[
"LoungeLight",
"Hue",
"Ambilight"
],
"menuitems":[
"Setup_Menu"
],
"textentry":[
"context_based",
"initial_string_available",
"editor_info_available"
],
"applications":[
"TV_Apps",
"TV_Games",
"TV_Settings"
],
"pointer":[
"not_available"
],
"inputkey":[
"key"
],
"activities":[
"intent"
],
"channels":[
"preset_string"
],
"mappings":[
"server_mapping"
]
},
"systemfeatures":{
"tvtype":"consumer",
"content":[
"dmr",
"dms_tad"
],
"tvsearch":"intent",
"pairing_type":"digest_auth_pairing",
"secured_transport":"true"
}
}
} This command is switches to HDMI channel 2 (for me):
|
@nstrelow Play/Pause is messy. On my TV the actual playpause toggle key is broken. So i send a spacebar command instead. Which is commonly used for playpause. Does the PlayPause key work normally on your TV using your component? |
Ps.. the serial number in above data is not actually empty right? I hope you redacted it? |
I did. Will test further things, if I find the time, extract the apks. |
I've resolved the post merge comments in: #46422 |
Proposed change
Known Issues
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: