Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xiaomi_miio vacuum service to load map #46852

Closed
wants to merge 1 commit into from

Conversation

paoloantinori
Copy link
Contributor

Breaking change

Proposed change

xiao_mii, added service for vacuum device to load maps.
See https://community.home-assistant.io/t/xiaomi-vacuum-restore-select-backup-map-multi-floor-support/282345

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@MartinHjelmare MartinHjelmare changed the title xiao_mii: vacuum, added service for to load map Add xiaomi_miio vacuum service to load map Feb 22, 2021
@frenck
Copy link
Member

frenck commented Mar 16, 2021

According to the response on the forum; this should not work:

https://community.home-assistant.io/t/xiaomi-vacuum-restore-select-backup-map-multi-floor-support/282345/4

Also, listed in that same thread by you, that you were not able to test it?

@paoloantinori
Copy link
Contributor Author

paoloantinori commented Mar 16, 2021

Yes, sorry, we can probably stash this for now. It seems that the base library providing the future is not really working, so despite being this PR functionally correct, it won't provide the desired behavior.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants