Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up discovery integration #47022

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Clean up discovery integration #47022

merged 3 commits into from
Feb 25, 2021

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 24, 2021

Breaking change

Proposed change

Remove services from discovery integration that are already taken care off by hooking into the other discoveries (zeroconf/ssdp) or are not being used anymore.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @fredrike, mind taking a look at this pull request as its been labeled with an integration (daikin) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as its been labeled with an integration (freebox) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Quentame
Copy link
Member

Such a coincidence, I've started a discovery rework on the freebox integration 😄

PR should come soon.

@Quentame Quentame mentioned this pull request Feb 25, 2021
21 tasks
@Quentame
Copy link
Member

Freebox discovery PR created #47045

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 1989b8c into dev Feb 25, 2021
@MartinHjelmare MartinHjelmare deleted the discovery-reduce-scope branch February 25, 2021 11:19
@Quentame
Copy link
Member

conflicts resolved

@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants