Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to reverse switch behaviour in KMTronic #47532

Merged
merged 17 commits into from Mar 8, 2021

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented Mar 6, 2021

Proposed change

Addresses issue #47443

Some of KMTronic models expose the relay 3 contacts (NO, COM, NC). Usually you use a relay with NO and COM (for failsafe reasons), but you can also use NC and COM since it is exposed. This PR adds the option "reverse" in order to work in systems where NC and COM are used.

NC=Normally Connected
NO=Normally Open
COM=Common

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Mar 6, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 6, 2021
@dgomes dgomes mentioned this pull request Mar 7, 2021
21 tasks
@dgomes dgomes added this to the 2021.3.3 milestone Mar 7, 2021
homeassistant/components/kmtronic/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/kmtronic/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/kmtronic/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/kmtronic/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/kmtronic/config_flow.py Outdated Show resolved Hide resolved
tests/components/kmtronic/test_switch.py Outdated Show resolved Hide resolved
tests/components/kmtronic/test_switch.py Outdated Show resolved Hide resolved
tests/components/kmtronic/test_switch.py Outdated Show resolved Hide resolved
tests/components/kmtronic/test_switch.py Outdated Show resolved Hide resolved
tests/components/kmtronic/test_init.py Outdated Show resolved Hide resolved
Dev automation moved this from By Code Owner to Review in progress Mar 8, 2021
@balloob balloob removed this from the 2021.3.3 milestone Mar 8, 2021
@balloob
Copy link
Member

balloob commented Mar 8, 2021

Removing this from the milestone as it's a new feature.

@dgomes
Copy link
Contributor Author

dgomes commented Mar 8, 2021

it's a feature fixing an issue 😅

Dev automation moved this from Review in progress to Reviewer approved Mar 8, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit ee25723 into home-assistant:dev Mar 8, 2021
Dev automation moved this from Reviewer approved to Done Mar 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2021
@dgomes dgomes deleted the kmtronic_reverse branch April 7, 2022 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

KMTRONIC integration - display reversed status
4 participants