New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to reverse switch behaviour in KMTronic #47532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
bugfix
has-tests
integration: kmtronic
new-feature
small-pr
PRs with less than 30 lines.
by-code-owner
labels
Mar 6, 2021
MartinHjelmare
requested changes
Mar 8, 2021
Removing this from the milestone as it's a new feature. |
it's a feature fixing an issue 😅 |
MartinHjelmare
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
by-code-owner
cla-signed
has-tests
integration: kmtronic
new-feature
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Addresses issue #47443
Some of KMTronic models expose the relay 3 contacts (NO, COM, NC). Usually you use a relay with NO and COM (for failsafe reasons), but you can also use NC and COM since it is exposed. This PR adds the option "reverse" in order to work in systems where NC and COM are used.
NC=Normally Connected
NO=Normally Open
COM=Common
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: