Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KMTronic Integration #41682

Merged
merged 18 commits into from Feb 22, 2021
Merged

Add KMTronic Integration #41682

merged 18 commits into from Feb 22, 2021

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented Oct 11, 2020 •
edited

Proposed change

Add support for KMtronic Web Relay's

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Oct 11, 2020
@dgomes dgomes changed the title KMTronic Web Relays KMTronic Integration Oct 11, 2020
@dgomes dgomes mentioned this pull request Oct 11, 2020
Merged
11 tasks
@springstan springstan changed the title KMTronic Integration Add KMTronic Integration Oct 12, 2020
@cgarwood cgarwood added this to Incoming in New Integrations via automation Nov 25, 2020
This was referenced Dec 18, 2020
Closed
Merged
davet2001
davet2001 reviewed Dec 22, 2020
View reviewed changes
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had a quick look through, nothing major so far.

homeassistant/components/kmtronic/translations/en.json Outdated Show resolved Hide resolved
bdraco
bdraco requested changes Feb 21, 2021
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments above.

Thanks!

Dev automation moved this from Needs review to Review in progress Feb 21, 2021
New Integrations automation moved this from Incoming to Awaiting Requested Changes Feb 21, 2021
dgomes and others added 2 commits February 21, 2021 18:54
@dgomes @bdraco
Update homeassistant/components/kmtronic/switch.py
4ac3fa0 
Co-authored-by: J. Nick Koston <nick@koston.org>
@dgomes
fix
65ec450
bdraco
bdraco approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Dev automation moved this from Review in progress to Reviewer approved Feb 21, 2021
New Integrations automation moved this from Awaiting Requested Changes to Reviewer approved Feb 21, 2021
@bdraco bdraco merged commit 5c29ade into home-assistant:dev Feb 22, 2021
Dev automation moved this from Reviewer approved to Done Feb 22, 2021
New Integrations automation moved this from Reviewer approved to Done Feb 22, 2021
dx44 added a commit to dx44/core that referenced this pull request Feb 24, 2021
@dx44 @Noltari
@MartinHjelmare @frenck @tkdrob @homeassistant @bdraco @MatthewFlamm @foxel @kpine @allenporter @palfrey @javicalle @janiversen @amelchio @raman325 @uvjustin @emontnemery @spike411 @thecode @ludeeus @nielstron @starkillerOG @fronzbot @ollo69 @marecabo @bramkragten @elupus @dmcc @marthoc @esev @scop @mdz @balloob @leikoilja @badguy99 @cgtobi @gsemet @jcam @spacegaier @AdmiralStipe @emichael @shbatm @dependabot @oetken @fabaff @ctalkington @mib1185 @farmio @crazyfx1 @milanmeu @puddly @teharris1 @StevenLooman @G-Two @OnFreund @donkawechico @cgarwood @dgomes @decompil3d @jwnmulder @austinmroczek @kukulich @chemelli74 @macrosak @natekspencer
Update from HACF (#1)
d1952e6 
* Add AEMET OpenData integration (home-assistant#45074)

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Improve Elgato code quality (home-assistant#46505)

* Use core constants for sma (home-assistant#46501)

* Use core constants for rpi_rf (home-assistant#46500)

* Use core constants for rmvtransport (home-assistant#46502)

* [ci skip] Translation update

* Update tuya for new fan entity model (home-assistant#45870)

* Fix missing condition in nws (home-assistant#46513)

* Use core constants for temper (home-assistant#46508)

* Use core constants for switcher_kis (home-assistant#46507)

* Use core constants for thethingsnetwork (home-assistant#46520)

* Use core constants for trend (home-assistant#46521)

* Add hive hub 360 sensors (home-assistant#46320)

* Clean up template (home-assistant#46509)

* Add keenetic_ndms2 config flow (home-assistant#38353)

* Add barrier covers to zwave_js integration (home-assistant#46379)

* Improve nest defense against broken event loop on shutdown (home-assistant#46494)

* Cleanup unused loggers (home-assistant#46510)

* Don't allow recursive secrets loading (home-assistant#41812)

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Add myself to RFLink codeowners (home-assistant#46511)

* Update modbus test harness (home-assistant#44892)

* Update test harness to allow discovery_info testing.

This is a needed update, before the whole config is converted
to the new structure, because it allows test of both the old
and new configuration style.

The following changes have been made:
- Combine test functions into a single base_test.
- Prepare for new mock by combining the 2 common test functions into one.
- Change mock to be only modbusHub
- Do not replace whole modbus class, but only the class that
  connects to pymodbus (modbusHub). This allows test of modbus
  configurations and not only component configurations, and is needed
  when testing discovery activated platform.
- Add test of climate.
  Warning this is merely test of discovery,
  the real cover tests still needs to be added.
- Add test of cover.
  Warning this is merely test of discovery,
  the real cover tests still needs to be added.

* Update comment for old config

* Do not use hass.data, but instead patch pymodbus library.

* Add test of configuration (old/new way as available).

* Move assert to test function.

Make assert more understandable by removing it from the helper.

add base_config_test (check just calls base_test) to make it clear if
test is wanted or just controlling the config.

* use setup_component to load Modbus since it is an integration.

* Optimized flow in test helper.

* Do not trigger when template is true at startup (home-assistant#46423)

* Add support for pre-filtering events to the event bus (home-assistant#46371)

* Use core constants for vasttrafik (home-assistant#46539)

* Fix variable name from script refactoring (home-assistant#46503)

* Use core constants for uvc (home-assistant#46538)

* Use core constants for volvooncall (home-assistant#46543)

* Use core constants for wemo (home-assistant#46544)

* Fix typing on tuya fan percentage (home-assistant#46541)

* [ci skip] Translation update

* Add additional supported feature support to universal media player (home-assistant#44711)

* add additional supported feature support to universal media player

* add missing services

* Use core constants for wemo and whois (home-assistant#46548)

* Allow users to set device class for universal media player (home-assistant#46550)

* Add additional stream HLS payload tests (home-assistant#46517)

* Add tests for HLS playlist view details

* Add tests for hls playlist payloads

* Update tests/components/stream/test_hls.py

Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com>

* Update tests/components/stream/test_hls.py

Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com>

* Update tests/components/stream/test_hls.py

Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com>

* Update tests/components/stream/test_hls.py

Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com>

* Update tests/components/stream/test_hls.py

Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com>

* Update tests/components/stream/test_hls.py

Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com>

* Update tests/components/stream/test_hls.py

Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com>

Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com>

* Remove @home-assistant/core from MQTT codeowners (home-assistant#46562)

* Bump hatasmota to 0.2.9 (home-assistant#46561)

* Convert better from byte value to percentage in futurenow (home-assistant#45042)

Co-authored-by: Franck Nijhof <frenck@frenck.nl>

* Log ffmpeg errors for homekit cameras (home-assistant#46545)

* Use httpx in generic camera (home-assistant#46576)

* Use httpx in generic camera

* Remove commented out code

* MQTT cover Bugfixes (home-assistant#46479)

* MQTT cover Bugfixes

* Remove period

* Add websocket handlers to hassio (home-assistant#46571)

* Limit fronius error messages on failed connection (home-assistant#45824)

* Do not print several error messages on failed connection

* Change wrapping of exception, implement available

* Simplify exception flow

* Remove unnecessary init

* Add available property to actual entities

* Rebase and formatting

* Refactor stream worker responsibilities for segmenting into a separate class (home-assistant#46563)

* Remove stream_worker dependencies on Stream

Removee stream_worker dependencies on Stream and split out the logic
for writing segments to a stream buffer.

* Stop calling internal stream methods

* Update homeassistant/components/stream/worker.py

Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com>

* Reuse self._outputs when creating new streams

Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com>

* Fix issue with timeout and error response (home-assistant#46584)

* Add config flow to Xiaomi Miio switch (home-assistant#46179)

* Upgrade blinkpy to 0.17.0 (home-assistant#46581)

* Use shared clientsession for sense (home-assistant#46419)

* Upgrade sentry-sdk to 0.20.2 (home-assistant#46590)

* Use core constants for xiaomi_aqara (home-assistant#46551)

* [ci skip] Translation update

* Bump tuyaha to 0.0.10 and fix set temperature issues (home-assistant#45732)

* Add device_class attribute to ESPHome sensor entities (home-assistant#46595)

* Remove support for migrating pre-config entry homekit (home-assistant#46616)

HomeKit pairings and accessory ids from versions 0.109 and earlier are no longer
migrated on upgrade. Users upgrading directly to 2021.3 from 0.109
and older should upgrade to 2021.2 first if they wish to preserve
HomeKit configuration and avoid re-pairing the bridge.

This change does not affect upgrades from 0.110 and later.

* Add target to services.yaml (home-assistant#46410)

Co-authored-by: Franck Nijhof <git@frenck.dev>

* Use explicit open/close for covers (home-assistant#46602)

* Remove defunct CoinMarketCap integration (home-assistant#46615)

* Bump python-vlc-telnet to 2.0.1 (home-assistant#46608)

Includes corresponding Home Assistant changes to avoid introducing
regressions.

* Use core constants for yeelight (home-assistant#46552)

* Use update coordinator for Xioami Miio subdevices (home-assistant#46251)

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Fix vlc_telnet state update (home-assistant#46628)

* Clean up

* Add debug logs

* Fix info lookup

* Handle more errors

* Guard get length and time

* Remove unnecessary constants from universal (home-assistant#46537)

* Separate HLS logic out of core StreamOutput to prepare for discontinuity (home-assistant#46610)

Separate the HLS stream view logic out of StreamOutput since the hls
stream view is about to get more complex to track discontinuities. This
makes the idle timeout, shutdown, and coupling between hls and record
more explicit.

* Fix climate hold bug in ecobee (home-assistant#46613)

* Do not provide icon if device class is set in ESPHome config (home-assistant#46650)

* Fix exception in stream idle callback (home-assistant#46642)

* Fix exception in stream idle callback

Fix bug where idle timeout callback fails if the stream previously exited.

* Add a test for stream idle timeout after stream is stopped.

* Add clarifying comment to idle timer clear method

* Clear hls timer only on stop

* Fix KeyError in comfoconnect percentage (home-assistant#46654)

* Fix version of pip in tox (home-assistant#46656)

* [ci skip] Translation update

* Fix stream keepalive on startup (home-assistant#46640)

This was accidentally dropped in a previous PR that refactored the interaction
between stream and camera. This is difficult to test from the existing
preload stream tests, so leaving untested for now.

* Add SmartTub integration (home-assistant#37775)

Co-authored-by: J. Nick Koston <nick@koston.org>

* Fix media_pause in vlc_telnet (home-assistant#46675)

The underlying python-telnet-vlc pause() function toggles play/pause, so
we need to check our state before calling it.

* Fix Cloud Google/Alexa check (home-assistant#46681)

* Add back block_until_done calls removed in PR 46610 (home-assistant#46680)

* Add sensors to fetch Habitica tasks (home-assistant#38910)

* Adding sensors to fetch habitica tasks

* PR changes and rebase

* Fixing pylint

* Fixing failed test dependancy

* Generating requirements

* Apply suggestions from code review

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* PR changes

* Update homeassistant/components/habitica/config_flow.py

Thank you, @MartinHjelmare

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* PR Changes

* Fix failing test

* Update tests/components/habitica/test_config_flow.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Fixing linting and imports

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Remove exception handling for AttributeError in wemo (home-assistant#46674)

* Fix multiple motion blinds gateways (home-assistant#46622)

local variable multicast was undefined for a second or more gateway that was setup.

* Home connect use consts (home-assistant#46659)

* Use more consts

* black

* re-black with black, version 20.8b1

* Fix flaky stream tests due to race in idle timeout callback (home-assistant#46687)

* Fix Tuya Option Flow tests (home-assistant#46651)

* Clean up xbee (home-assistant#46549)

* Increase async_timeout for wemo update polling (home-assistant#46649)

* Remove calls to wemo.reconnect_with_device (home-assistant#46646)

* Bump RMVtransport to v0.3.0 (home-assistant#46691)

* Discover HRT4-ZW / SRT321 SetPoint in zwave_js (home-assistant#46625)

Missing a specific class to allow discovery of the setpoint command.

Fix home-assistant#46570

Signed-off-by: Gaetan Semet <gaetan@xeberon.net>

* Update zha to use new fan entity model (home-assistant#45758)

* Update zha to use new fan entity model

* fixes

* tweaks for zha

* pylint

* augment test cover

* Centralize wemo exception handling (home-assistant#46705)

* Perform wemo state update quickly after a timeout (home-assistant#46702)

* Perform state update quickly after a timeout

* with async_timeout.timeout(...) -> async with async_timeout.timeout(...)

* [ci skip] Translation update

* Bump pylutron 0.2.7 (home-assistant#46717)

* Switch ssdp to be async by using async_upnp_client for scanning (home-assistant#46554)

SSDP scans no longer runs in the executor

This is an interim step that converts the async_upnp_client
response to netdisco's object to ensure fully backwards
compatibility

* Add selectors to Input * service definitions (home-assistant#46652)

* Add selectors to Alert service definitions (home-assistant#46627)

* Add selectors to Camera service definitions (home-assistant#46630)

* Add selectors to Switch service definitions (home-assistant#46635)

* Add selectors to Downloader service definitions (home-assistant#46638)

* Add selectors to Fan service definitions (home-assistant#46639)

* Add selectors to Cover service definitions (home-assistant#46634)

Co-authored-by: Tobias Sauerwein <cgtobi@users.noreply.github.com>

* Add selectors to Automation service definitions (home-assistant#46629)

* Add selectors to Climate service definitions (home-assistant#46632)

* Add selectors to Alarm Control Panel service definitions (home-assistant#46626)

* Upgrade and constrain httplib2>=0.19.0 (home-assistant#46725)

* ubus: switch to pypi library (home-assistant#46690)

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

* Add selectors to Counter service definitions (home-assistant#46633)

* Add advanced service parameter flag (home-assistant#46727)

* Add discontinuity support to HLS streams and fix nest expiring stream urls (home-assistant#46683)

* Support HLS stream discontinuity.

* Clarify discontinuity comments

* Signal a stream discontinuity on restart due to stream error

* Apply suggestions from code review

Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com>

* Simplify stream discontinuity logic

* Add selectors to Scene service definitions (home-assistant#46729)

* Fix missing color switch specific device class for Z-Wave JS driver >6.3 (home-assistant#46718)

* Add selectors to Netatmo services (home-assistant#46574)

* Add selectors

* Fix schedul selector

* Update homeassistant/components/netatmo/services.yaml

Co-authored-by: Bram Kragten <mail@bramkragten.nl>

* Update homeassistant/components/netatmo/services.yaml

Co-authored-by: Bram Kragten <mail@bramkragten.nl>

* Update services.yaml

* Added required field

Co-authored-by: Bram Kragten <mail@bramkragten.nl>

* Add selectors to Vacuum service definitions (home-assistant#46728)

* Add selectors to Script service definitions (home-assistant#46730)

* Add advanced selectors to Light service definitions (home-assistant#46732)

* Add selectors to WLED service definitions (home-assistant#46731)

* Add advanced selectors to Climate service definitions (home-assistant#46736)

* Add selectors to Z-Wave JS service definitions (home-assistant#46737)

* Add selectors to Logger, System Log & Logbook service definitions (home-assistant#46740)

* Add selectors to MQTT service definitions (home-assistant#46738)

* Add selectors to Color Extractor service definitions (home-assistant#46742)

* Add selectors to Lock service definitions (home-assistant#46743)

* Add selectors to Timer service definitions (home-assistant#46744)

* Skip repeated segment in stream recorder (home-assistant#46701)

* Skip repeated segment in stream recorder

* Allow for multiple overlap

* Fix typo in Tesla Powerwall strings (home-assistant#46752)

* Add selectors to Hue service definitions (home-assistant#46747)

* Add selectors to Media Player service definitions (home-assistant#46739)

* Add selectors to Toon service definitions (home-assistant#46750)

* Add selectors to Browser, Recorder, Shopping List service definitions (home-assistant#46749)

* Add selectors to Conversation, Image Processing and Number service definitions (home-assistant#46746)

* Minor service definition tweaks (home-assistant#46741)

* Added Slovenian language (sl-si) to Microsoft TTS (home-assistant#46720)

* Add selectors to HomeKit service definitions (home-assistant#46745)

* Add selectors to Twente Milieu service definitions (home-assistant#46748)

* Ensure pre-commit's hassfest triggers on service file changes (home-assistant#46753)

* Add selectors to Home Assistant service definitions (home-assistant#46733)

Co-authored-by: Bram Kragten <mail@bramkragten.nl>

* Upgrade sentry-sdk to 0.20.3 (home-assistant#46754)

* Allow LIFX bulbs to fade color even when off (home-assistant#46596)

LIFX bulbs have the capability to fade their color attributes even while the bulb is off. When the bulb is later turned on, the fade will continue as if the bulb was on all along.

* Add @esev as codeowner for wemo (home-assistant#46756)

* Upgrade cryptography to 3.3.2 (home-assistant#46759)

* [ci skip] Translation update

* Address late smarttub review (home-assistant#46703)

* _config -> config

* remove unused string

* remove entity tests

* replace unit tests with integration tests using the core

* refactor polling to use asyncio.gather

* remove redundant component init

* remove gather in favor of simple loop

* use async_fire_time_changed instead of async_update_entity

* use hass.config_entries.async_setup instead of calling smarttub.async_setup_entry directly

* replace stray smarttub.async_setup_entry call

* async_unload_entry -> hass.config_entries.async_unload

* remove broken test

* Fix flip-flopped substitutions in Custom Version Type Warning message. (home-assistant#46768)

* Implement percentage step sizes for fans (home-assistant#46512)

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>

* Fix backwards compatibility with vesync fans (home-assistant#45950)

* Bump actions/stale from v3.0.16 to v3.0.17 (home-assistant#46777)

* Raise ConditionError for zone errors (home-assistant#46253)

* Raise ConditionError for zone errors

* Do not test missing state

* Handle multiple entities/zones

* Raise ConditionError for and/or/not errors (home-assistant#46767)

* Bump RMVtransport to 0.3.1 (home-assistant#46780)

* Add Home Assistant color (home-assistant#46751)

* Use string instead of slug for add-on slug validation (home-assistant#46784)

* Allow multiple recipients for XMPP (home-assistant#45328)

* recipient is a string list instead of a single string now
* this does NOT break existing automations/etc using this component

* Update GitHub Issue Form template (home-assistant#46791)

This PR fixes the bug report template!

Details: https://gh-community.github.io/issue-template-feedback/changes/#what-do-i-need-to-do

* Add zwave_js thermostat fan mode and fan state support (home-assistant#46793)

* add thermostat fan mode and fan state support

* return when fan mode is not supported

* use get just in case

* validate state key is in states so we dont have to use get

* pylint

* Format zwave_js dump as json (home-assistant#46792)

* [ci skip] Translation update

* Bump pywemo to 0.6.2 (home-assistant#46797)

* Implement suggested_area in the device registry (home-assistant#45940)

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>

* Cleanup inconsistencies in zha fan and make it a bit more dry (home-assistant#46714)

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Add support for using a single endpoint for rest data (home-assistant#46711)

* Add device_entities template function/filter (home-assistant#46406)

* Add suggested area support to nuheat (home-assistant#46801)

* Fix typing of fan speed count and steps (home-assistant#46790)

* Implement suggested area for netatmo (home-assistant#46802)

* Add suggested area to nexia (home-assistant#46776)

* Add suggested area to hunterdouglas_powerview (home-assistant#46774)

* Ensure recorder shuts down cleanly on restart before startup is finished (home-assistant#46604)

* Ensure HomeAssistant can still restart when a library file is missing (home-assistant#46664)

* Implement suggested area in lutron_caseta (home-assistant#45941)

* Implement percentage step sizes in HomeKit (home-assistant#46722)

* Update smarty to use new fan entity model (home-assistant#45879)

* Update alexa for new fan model (home-assistant#45836)

* Implement suggested areas in bond (home-assistant#45942)

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>

* Recover and restart the recorder if the sqlite database encounters corruption while running (home-assistant#46612)

* Add suggested area support to Sonos (home-assistant#46794)

* Run homekit service calls in async since the server is now async (home-assistant#45859)

* Simplify homekit runs and service calls

Now that the homekit server is async, call_service
and run are running in the Home Assistant event loop

* remove comment

* remove another comment

* Do not trigger when numeric_state is true at startup (home-assistant#46424)

* Bump zwave-js-server-python to 0.18.0 (home-assistant#46787)

* updates to support changes in zwave-js-server-python

* bump lib version

* use named arguments for optional args

* re-add lost commits

* Rollback stream StreamOutput refactoring in PR#46610 (home-assistant#46684)

* Rollback PR#46610

* Update stream tests post-merge

* Upgrade TwitterAPI to 2.6.6 (home-assistant#46812)

* Update rokuecp to 0.8.0 (home-assistant#46799)

* update rokuecp to 0.8.0

* Update requirements_test_all.txt

* Update requirements_all.txt

* Add support for bond up and down lights (home-assistant#46233)

* Add rtsp transport options to generic camera (home-assistant#46623)

* Add rtsp transport options to generic camera

* change log level to info (home-assistant#46823)

* Update xknx to 0.17.0 (home-assistant#46809)

* Detect iBlinds v2.0 switch value as a cover not light (home-assistant#46807)

* Remove unused "fibaro_fgs222" discovery hint

* Simplify multilevel switch current value discovery schema

* Force iBlinds v2.0 devices to be discovered as cover entities

* Rename discovery test file

* Implement suggested area in roku (home-assistant#46819)

* implement suggested area in roku

* Update const.py

* Update test_media_player.py

* Update test_media_player.py

* Update test_media_player.py

* Update test_media_player.py

* Explicitly create_task for asyncio.wait (home-assistant#46325)

* Validate icon and device_class of ESPHome sensor entities (home-assistant#46709)

* Enable KNX routing optional local_ip (home-assistant#46133)

* knx-read-service (home-assistant#46670)

* Add open/close tilt support to KNX cover (home-assistant#46583)

* Bump pywemo to 0.6.3 (home-assistant#46825)

* Disable update polling for Wemo when devices can push updates (home-assistant#46806)

* Fix habitica entry unload clean up (home-assistant#46798)

* Fix habitica entry unload clean up

* Fix service remove

* Add entry setup and unload test

* Fix config flow tests

* Assert service

* Speed-up wemo discovery (home-assistant#46821)

* Speed-up wemo discovery

* Use gather_with_concurrency to limit concurrent executor usage

* Comment fixup: asyncio executors -> executor threads

* Add Rituals Perfume Genie integration (home-assistant#46218)

Co-authored-by: J. Nick Koston <nick@koston.org>

* Bump zigpy-znp from 0.3.0 to 0.4.0 (home-assistant#46828)

* Add smarttub sensor platform and state sensor (home-assistant#46775)

* Fix Insteon config flow with add X10 and device override (home-assistant#45854)

* [ci skip] Translation update

* Allow upnp ignore SSDP-discoveries (home-assistant#46592)

* Add new Subaru integration (home-assistant#35760)

Co-authored-by: On Freund <onfreund@gmail.com>
Co-authored-by: J. Nick Koston <nick@koston.org>

* Add support for "alias" in script steps device, device_condition, and conditions (home-assistant#46647)

Co-authored-by: Donnie <donniekarnsinsb@hotmail.com>

* Add support for disabling config entries (home-assistant#46779)

* Add support for preset modes in homekit fans (home-assistant#45962)

* Cleanup recorder tests (home-assistant#46836)

* Refine printing of ConditionError (home-assistant#46838)

* Refine printing of ConditionError

* Improve coverage

* name -> type

* Fix unmocked I/O in rituals_perfume_genie config flow test (home-assistant#46862)

* Log zwave_js connection errors (home-assistant#46867)

* [ci skip] Translation update

* Clean up denonavr constants (home-assistant#46883)

* Clean up acer_projector constants (home-assistant#46880)

* Add more sensors to SmartTub integration (home-assistant#46839)

* Add weather platform to template domain (home-assistant#45031)

Co-authored-by: J. Nick Koston <nick@koston.org>

* Add support for SmartTub heat modes (home-assistant#46876)

* Add switch platform and pump entity to SmartTub (home-assistant#46842)

* Add support for VeSync dimmer switches (home-assistant#44713)

Co-authored-by: J. Nick Koston <nick@koston.org>

* Log the name of automations with condition errors (home-assistant#46854)

* Add support for SmartTub filtration cycles (home-assistant#46868)

* Add KNX service exposure_register (home-assistant#45257)

* Add light platform to SmartTub (home-assistant#46886)

Co-authored-by: J. Nick Koston <nick@koston.org>

* Add KMTronic Integration (home-assistant#41682)

Co-authored-by: J. Nick Koston <nick@koston.org>

* Add UV sensor to SmartTub (home-assistant#46888)

* Expose locked attribute in deCONZ climate platform (home-assistant#46814)

* Handle ConditionError with multiple entity_id for state/numeric_state (home-assistant#46855)

* Add usercode support to totalconnect (home-assistant#39199)

* Add test for invalid usercode

* Add usercodes to totalconnect.

* Update existing tests for usercodes

* Fix tests

* Add test for invalid usercode

* Add usercodes to totalconnect.

* Update existing tests for usercodes

* Fix tests

* Remove YAML support

* Fix conflict

* Bump to total_connect_client 0.56

* Change Exception to HomeAssistantError

* Fix config_flow.py

* Simplify async_setup since no yaml

* Remove import from config flow and tests

* Add reauth and test for it.  Various other fixes.

* Fix pylint in __init__

* Show config yaml as deprecated

* separate config_flow and init tests

* Assert ENTRY_STATE_SETUP_ERROR in init test

* Add test for reauth flow

* Fix reauth and tests

* Fix strings

* Restore username and usercode with new passord

* Correct the integration name

* Update tests/components/totalconnect/test_config_flow.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update tests/components/totalconnect/test_init.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update .coveragerc

* Add test for invalid auth during reauth

* Bump total-connect-client to 0.57

* Fix .coveragerc

* More tests for usercodes

* Fix usercode test

* Reload config entry on reauth

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Upgrade mypy to 0.812 (home-assistant#46898)

* Add Xiaomi Miio vacuum config flow (home-assistant#46669)

* Bump samsungtvws from 1.4.0 to 1.6.0 (home-assistant#46878)

* Add device_class to Shelly cover domain (home-assistant#46894)

Fix author

* Cleanup of possibily confusing comment in esphome (home-assistant#46903)

* Add binary sensor to SmartTub for online status (home-assistant#46889)

* Clean up constants (home-assistant#46885)

* Add name to services (home-assistant#46905)

* Add service names to Netatmo services (home-assistant#46909)

* add name and target filter to zwave_js lock services.yaml (home-assistant#46914)

* Increase tado API polling interval to 5 minutes (home-assistant#46915)

Polling interval of 15 seconds causes high load on tado servers and does
not provide enough value to warrant it. tado plans to introduce a rate
limit to prevent such misuse of the API, therefore the polling interval
needs to be increased to make sure the integration works well in the
future.

* Add name and target filter to vizio entity service (home-assistant#46916)

* Add name and target filter to vizio entity service

* Update homeassistant/components/vizio/services.yaml

Co-authored-by: Franck Nijhof <frenck@frenck.nl>

* add selectors

* Update homeassistant/components/vizio/services.yaml

Co-authored-by: Franck Nijhof <frenck@frenck.nl>

* Update homeassistant/components/vizio/services.yaml

Co-authored-by: Franck Nijhof <frenck@frenck.nl>

* Update homeassistant/components/vizio/services.yaml

Co-authored-by: Franck Nijhof <frenck@frenck.nl>

Co-authored-by: Franck Nijhof <frenck@frenck.nl>

* Add litterrobot integration (home-assistant#45886)

* Test zwave_js GE 12730 fan controller device-specific discovery (home-assistant#46840)

* Add test for GE 12730 fan controller device-specific discovery

* Adjust

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Clean up Mitemp_bt constants (home-assistant#46881)

* Use core constants for acer_projector

* Use core constants for mitemp_bt

* remove acer changes

* Description tweaks for automation services (home-assistant#46926)

* Update frontend to 20210222.0 (home-assistant#46928)

* Add get_config_parameters websocket command to zwave_js (home-assistant#46463)

* Add get_configuration_values websocket command to zwave_js

* Tweak return value

* Review comments and cleanup returned values

* Update test

* Rename to get_config_parameters

* Add get_configuration_values websocket command to zwave_js

* Rename to get_config_parameters

* fix test

* fix tests home-assistant#2

* Add readable to metadata

Co-authored-by: Raman Gupta <7243222+raman325@users.noreply.github.com>

* Add missing required=true to code slot field in zwave_js.set_lock_usercode service (home-assistant#46931)

* Add zwave_js/get_log_config and zwave_js/update_log_config WS API commands (home-assistant#46601)

* Add zwave_js.update_log_config service

* fix comment

* reduce lines

* move update_log_config from service to ws API call

* fix docstring

* Add zwave_js/get_log_config WS API command

* resolve stale comments

* remove transports since it will be removed from upstream PR

* add support to update all log config parameters since they could be useful outside of the UI for advanced users

* fix comment

* switch to lambda instead of single line validator

* fix rebase

* re-add ATTR_DOMAIN

* [ci skip] Translation update

* Add zwave_js set_config_parameter WS API command (home-assistant#46910)

* add WS API command

* handle error scenario better

* fixes and remove duplicate catch

* make elif statement more compact

* fix conflict

* switch to str(err)

* Restore stream recorder functionality and add discontinuity support (home-assistant#46772)

* Add discontinuity support to stream recorder

* Use same container options for both StreamOutputs

* Fix pts adjuster

* Remove redundant/incorrect duplicate hls segment check

* Use same StreamBuffer across outputs

* Remove keepalive check for recorder

* Set output video timescale explicitly

* Disable avoid_negative_ts

* Add suggested area to tado (home-assistant#46932)

I realized tado shows what we internally call `zone_name` as
the room name in the app.

* Update tasmota to use new fan entity model (home-assistant#45877)

* Add suggested area support to isy994 (home-assistant#46927)

Co-authored-by: Álvaro Fernández Rojas <noltari@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Franck Nijhof <git@frenck.dev>
Co-authored-by: tkdrob <tkdrob4390@yahoo.com>
Co-authored-by: HomeAssistant Azure <hello@home-assistant.io>
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com>
Co-authored-by: Khole <ktech6@outlook.com>
Co-authored-by: Andrey Kupreychik <foxel@quickfox.ru>
Co-authored-by: kpine <keith.pine@gmail.com>
Co-authored-by: Allen Porter <allen@thebends.org>
Co-authored-by: Tom Parker-Shemilt <palfrey@tevp.net>
Co-authored-by: javicalle <31999997+javicalle@users.noreply.github.com>
Co-authored-by: jan iversen <jancasacondor@gmail.com>
Co-authored-by: Anders Melchiorsen <amelchio@nogoto.net>
Co-authored-by: Raman Gupta <7243222+raman325@users.noreply.github.com>
Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com>
Co-authored-by: Erik Montnemery <erik@montnemery.com>
Co-authored-by: Lukáš Polívka <lukas.polivka@gmail.com>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Shay Levy <levyshay1@gmail.com>
Co-authored-by: Joakim Sørensen <joasoe@gmail.com>
Co-authored-by: Niels Mündler <n.muendler@tum.de>
Co-authored-by: starkillerOG <starkiller.og@gmail.com>
Co-authored-by: Kevin Fronczak <kfronczak@gmail.com>
Co-authored-by: ollo69 <60491700+ollo69@users.noreply.github.com>
Co-authored-by: marecabo <23156476+marecabo@users.noreply.github.com>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Joakim Plate <elupus@ecce.se>
Co-authored-by: David McClosky <notsoweird+github@gmail.com>
Co-authored-by: Mark Coombes <mark@markcoombes.ca>
Co-authored-by: Eric Severance <esev@esev.com>
Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
Co-authored-by: Matt Zimmerman <mdz@users.noreply.github.com>
Co-authored-by: David McClosky <dmcc@bigasterisk.com>
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
Co-authored-by: Ilja Leiko <leikoilja@users.noreply.github.com>
Co-authored-by: badguy99 <61918526+badguy99@users.noreply.github.com>
Co-authored-by: Tobias Sauerwein <cgtobi@users.noreply.github.com>
Co-authored-by: Gaetan Semet <gaetan@xeberon.net>
Co-authored-by: Jesse Campbell <hikeit@gmail.com>
Co-authored-by: Philip Allgaier <mail@spacegaier.de>
Co-authored-by: AdmiralStipe <64564398+AdmiralStipe@users.noreply.github.com>
Co-authored-by: Ellis Michael <emichael@users.noreply.github.com>
Co-authored-by: shbatm <tim.j.bond@gmail.com>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andreas Oetken <andreas@oetken.name>
Co-authored-by: Denise Yu <deniseyu@github.com>
Co-authored-by: Fabian Affolter <mail@fabian-affolter.ch>
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
Co-authored-by: Michael <35783820+mib1185@users.noreply.github.com>
Co-authored-by: Matthias Alphart <farmio@alphart.net>
Co-authored-by: Martin <pum.m@gmx.at>
Co-authored-by: Milan Meulemans <milan.meulemans@live.be>
Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Co-authored-by: Tom Harris <tomharris@harrisnj.net>
Co-authored-by: Steven Looman <steven.looman@gmail.com>
Co-authored-by: Garrett <7310260+G-Two@users.noreply.github.com>
Co-authored-by: On Freund <onfreund@gmail.com>
Co-authored-by: Donnie <donniekarnsinsb@hotmail.com>
Co-authored-by: Charles Garwood <cgarwood@gmail.com>
Co-authored-by: Diogo Gomes <diogogomes@gmail.com>
Co-authored-by: Jonathan Keslin <decompil3d@users.noreply.github.com>
Co-authored-by: Jan-Willem Mulder <jwnmulder@gmail.com>
Co-authored-by: Austin Mroczek <austin@mroczek.org>
Co-authored-by: Jaroslav Hanslík <kukulich@kukulich.cz>
Co-authored-by: Simone Chemelli <simone.chemelli@gmail.com>
Co-authored-by: Michal Knizek <mknizek@gmail.com>
Co-authored-by: Nathan Spencer <natekspencer@gmail.com>
MartinHjelmare
MartinHjelmare reviewed Mar 3, 2021
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some comments for a future PR.

homeassistant/components/kmtronic/config_flow.py
try:
info = await validate_input(self.hass, user_input)

return self.async_create_entry(title=info["host"], data=user_input)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only wrap the line that can raise inside the try... except block. Use an else: block if needed.

homeassistant/components/kmtronic/const.py Show resolved Hide resolved
homeassistant/components/kmtronic/__init__.py Show resolved Hide resolved
homeassistant/components/kmtronic/switch.py Show resolved Hide resolved
homeassistant/components/kmtronic/switch.py Show resolved Hide resolved
homeassistant/components/kmtronic/switch.py Show resolved Hide resolved
tests/components/kmtronic/test_config_flow.py Show resolved Hide resolved
tests/components/kmtronic/test_config_flow.py Show resolved Hide resolved
tests/components/kmtronic/test_switch.py Show resolved Hide resolved
dgomes added a commit to dgomes/home-assistant that referenced this pull request Mar 7, 2021
@dgomes
address review comments in home-assistant#41682
81d306e
@dgomes
Copy link
Contributor Author

dgomes commented Mar 7, 2021

Comments by @MartinHjelmare addressed in #47532

dgomes added a commit to dgomes/home-assistant that referenced this pull request Mar 7, 2021
@dgomes
address review comments in home-assistant#41682
07fbc41
@dgomes dgomes deleted the kmtronic branch April 7, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@davet2001 davet2001 davet2001 left review comments

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
cla-signed Hacktoberfest hacktoberfest-accepted has-tests integration: kmtronic new-integration
Projects
Dev
  
Done
New Integrations
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dgomes @bdraco @MartinHjelmare @davet2001 @homeassistant