New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deconz websocket fixture #47738
Closed
Closed
Deconz websocket fixture #47738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
code-quality
has-tests
integration: deconz
small-pr
PRs with less than 30 lines.
labels
Mar 10, 2021
Kane610
force-pushed
the
deconz-websocket_fixture
branch
from
March 10, 2021 21:43
89d51f5
to
f43bd2d
Compare
Maybe split the PR into one platform per PR? |
My initial thought since its mostly the same work in all files there was no need to split it. But if you want to I can |
It's a mix of changes and many lines. It's easier to set aside a smaller amount of time for each review. Bigger PRs will naturally get pushed back to end of the queue. |
I will split it during the afternoon |
This was referenced Mar 12, 2021
I've split this into multiple PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
code-quality
has-tests
integration: deconz
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
The Goal here was to become less dependent of integration specific mechanisms to verify states in the tests. Most is really about cosmetics and the core of tests have usually not been altered.
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: