Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use websocket fixture in deCONZ sensor tests #47830

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Mar 12, 2021

Breaking change

Proposed change

Depends on #47738
Use new websocket fixture
Localize test fixtures
Improve asserts

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Mar 12, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 12, 2021
Localize test data
Improve asserts
@Kane610 Kane610 force-pushed the deconz-sensor_use_websocket_fixture branch from 0898335 to 15a4f81 Compare March 12, 2021 20:37
@Kane610 Kane610 marked this pull request as ready for review March 12, 2021 20:41
@frenck frenck self-requested a review March 18, 2021 10:09
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 馃憤

One line missing, would be nice to address that in a future PR

----------- coverage: platform linux, python 3.9.2-final-0 -----------
Name                                                Stmts   Miss  Cover   Missing
---------------------------------------------------------------------------------
homeassistant/components/deconz/sensor.py             140      1    99%   172

Dev automation moved this from By Code Owner to Reviewer approved Mar 18, 2021
@Kane610
Copy link
Member Author

Kane610 commented Mar 18, 2021

Nice! 馃憤

One line missing, would be nice to address that in a future PR

----------- coverage: platform linux, python 3.9.2-final-0 -----------
Name                                                Stmts   Miss  Cover   Missing
---------------------------------------------------------------------------------
homeassistant/components/deconz/sensor.py             140      1    99%   172

Its on my ToDo :)

@frenck frenck merged commit a4b2dff into home-assistant:dev Mar 18, 2021
Dev automation moved this from Reviewer approved to Done Mar 18, 2021
@Kane610
Copy link
Member Author

Kane610 commented Mar 18, 2021

Thanks @frenck 馃帀

@Kane610 Kane610 deleted the deconz-sensor_use_websocket_fixture branch March 18, 2021 10:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants