Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verisure: Remove JSONPath, unique IDs, small cleanups #47870

Merged
merged 3 commits into from
Mar 14, 2021
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Mar 13, 2021

Proposed change

Another step in the Verisure integration cleanup/refactoring.

  • Moves the DataUpdateCoordinator into its own file.
  • Data is processed in the DataUpdateCoordinator, so it becomes easier to consume for Home Assistant.
  • Removed the need/use of JSONPath.
  • device_labels and such, are serial numbers (and referenced as such in Versisure now as well). Code adjusted to make that clear.
  • Added Unique IDs based on the serial numbers (where possible at this point).
  • Updated all available properties to take the DataUpdateCoordinator status into account.

This code is far from perfect, but is meant as a step forward. Got some more changes ready to go after this PR (e.g., Configuration flow with imports/discovery, devices, more unique IDs, lots more to clean up).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
verisure:
  username: test
  password: welcome1

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@frenck frenck mentioned this pull request Mar 13, 2021
25 tasks
@frenck frenck merged commit 60838cf into dev Mar 14, 2021
@frenck frenck deleted the frenck-2021-0864 branch March 14, 2021 09:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants