Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reauthentication to Verisure #47972

Merged
merged 5 commits into from
Mar 16, 2021
Merged

Add reauthentication to Verisure #47972

merged 5 commits into from
Mar 16, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Mar 15, 2021

Proposed change

This PR adds re-authentication handling to the Verisure integration.
Now possible because of: persandstrom/python-verisure#129
That PR has already been merged, released and bumped in our code base (in #47946).

image

We currently cannot check if 2FA is an issue, so this is the best we can do at this point. It will give instant feedback now (so no late surprises). Documentation is adjusted to this as well (PR separate from this PR: home-assistant/home-assistant.io#17013)

Next steps (after this PR):

  • Check if installation still exists on startup
  • Even more cleanup!
  • Pre-determine property values, instead of calculating them in property methods themselves (as much as possible)
  • Start setting up tests for platforms

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck changed the title Add devices to Verisure integration Add reauthentication to Verisure Mar 15, 2021
@frenck frenck marked this pull request as ready for review March 15, 2021 22:46
@frenck frenck mentioned this pull request Mar 15, 2021
@MartinHjelmare MartinHjelmare merged commit 354c0a7 into dev Mar 16, 2021
@MartinHjelmare MartinHjelmare deleted the frenck-2021-0885 branch March 16, 2021 07:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verisure integration
3 participants