Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old style type comments #49103

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Apr 12, 2021

Proposed change

Replace old style type comments for stream/core.py. I also noticed that the types probably won't work, since they don't correspond to any in PyAV/av/__init__.py. Instead they need to be imported from their respective packages.

Additionally AudioStream is only exported from av.audio.stream.AudioStream not av.audio.AudioStream. For a fix see: PyAV-Org/PyAV#775

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @hunterjm, @uvjustin, @allenporter, mind taking a look at this pull request as its been labeled with an integration (stream) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@cdce8p
Copy link
Member Author

cdce8p commented Apr 12, 2021

I needed to revert the part for AudioStream due to a pylint error (c-extension-no-member). Will do the change once PyAV-Org/PyAV#775 is merged and the av dependency updated.

@frenck frenck merged commit 885f528 into home-assistant:dev Apr 12, 2021
@cdce8p cdce8p deleted the type-hints-stream-av branch April 12, 2021 15:23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants