Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edl21 OBIS IDs for Holley DTZ541-ZEBA #49170

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Add edl21 OBIS IDs for Holley DTZ541-ZEBA #49170

merged 1 commit into from
Apr 13, 2021

Conversation

mtdcr
Copy link
Contributor

@mtdcr mtdcr commented Apr 13, 2021

Proposed change

Enable sensors for several OBIS IDs reported by Holley DTZ541-ZEBA electricity meters.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@mtdcr mtdcr mentioned this pull request Apr 13, 2021
@MartinHjelmare MartinHjelmare changed the title edl21: Add OBIS IDs for Holley DTZ541-ZEBA (#44878) Add edl21 OBIS IDs for Holley DTZ541-ZEBA (#44878) Apr 13, 2021
@MartinHjelmare MartinHjelmare changed the title Add edl21 OBIS IDs for Holley DTZ541-ZEBA (#44878) Add edl21 OBIS IDs for Holley DTZ541-ZEBA Apr 13, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit e9f0891 into home-assistant:dev Apr 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDL21: Unhandled sensor
3 participants