Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening cover via emulated_hue without specifying a position #49570

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

Tho85
Copy link
Contributor

@Tho85 Tho85 commented Apr 22, 2021

Proposed change

Fix opening cover through emulated_hue without specifying position / brightness, i.e. with payload {"on":true}

#48367 introduced a bug in a code path that was not tested properly. The service variable would be overwritten in line 529, immediately before checking against it in line 530. So the statement following the if clause in line 531 would be unreachable. This PR reverts the change.

Regarding the tests: The two existing tests test_close_cover and test_set_position_cover would both supply a brightness / position to the API, so the modified code path was essentially untested and the bug would go unnoticed. I reused the first test to test the code path without a specified position.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bdraco bdraco merged commit 66dbb17 into home-assistant:dev Apr 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants