Fix opening cover via emulated_hue without specifying a position #49570
+28
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix opening cover through
emulated_hue
without specifying position / brightness, i.e. with payload{"on":true}
#48367 introduced a bug in a code path that was not tested properly. The
service
variable would be overwritten in line 529, immediately before checking against it in line 530. So the statement following theif
clause in line 531 would be unreachable. This PR reverts the change.Regarding the tests: The two existing tests
test_close_cover
andtest_set_position_cover
would both supply a brightness / position to the API, so the modified code path was essentially untested and the bug would go unnoticed. I reused the first test to test the code path without a specified position.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: