Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutesync integration #49679

Merged
merged 30 commits into from
Apr 27, 2021
Merged

Conversation

currentoor
Copy link
Contributor

@currentoor currentoor commented Apr 25, 2021

Proposed change

Added Mutesync integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob marked this pull request as ready for review April 27, 2021 00:11
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general comment: is the brand "mutesync", "mütesync", "Mutesync" or "Mütesync"? It is used in different ways in user facing display.

.coveragerc Outdated Show resolved Hide resolved
homeassistant/components/mutesync/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/mutesync/strings.json Outdated Show resolved Hide resolved
@currentoor
Copy link
Contributor Author

currentoor commented Apr 27, 2021

As a general comment: is the brand "mutesync", "mütesync", "Mutesync" or "Mütesync"? It is used in different ways in user facing display.

The brand is "mütesync" the application is "mutesync", I'll fix.

homeassistant/components/mutesync/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/mutesync/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/mutesync/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/mutesync/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/mutesync/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/mutesync/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/mutesync/config_flow.py Outdated Show resolved Hide resolved
tests/components/mutesync/test_config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/mutesync/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/mutesync/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/mutesync/config_flow.py Outdated Show resolved Hide resolved
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@frenck
Copy link
Member

frenck commented Apr 27, 2021

@currentoor Would you mind me pushing onto this branch?
I've got a small update to simplify the tests and make them have a 100% coverage on the configuration flow.

@currentoor
Copy link
Contributor Author

@currentoor Would you mind me pushing onto this branch?
I've got a small update to simplify the tests and make them have a 100% coverage on the configuration flow.

Not at all, but how do I do that?

@frenck
Copy link
Member

frenck commented Apr 27, 2021

Sit back and relax 😉

@frenck
Copy link
Member

frenck commented Apr 27, 2021

Done that should do the trick 👍

@balloob balloob merged commit a577611 into home-assistant:dev Apr 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants