Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DS2405 support to onewire #50148

Merged
merged 1 commit into from May 20, 2021
Merged

Add DS2405 support to onewire #50148

merged 1 commit into from May 20, 2021

Conversation

epenet
Copy link
Contributor

@epenet epenet commented May 6, 2021 •
edited

Proposed change

Add DS2405 support to onewire

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev May 6, 2021
@probot-home-assistant
Copy link

Hey there @garbled1, mind taking a look at this pull request as its been labeled with an integration (onewire) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev May 6, 2021
@epenet epenet mentioned this pull request May 6, 2021
Merged
8 tasks
@epenet
Copy link
Contributor Author

epenet commented May 6, 2021

cc @klona

@epenet epenet mentioned this pull request May 20, 2021
Merged
21 tasks
janiversen
janiversen approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Dev automation moved this from By Code Owner to Reviewer approved May 20, 2021
@janiversen janiversen merged commit d7c0da9 into home-assistant:dev May 20, 2021
Dev automation moved this from Reviewer approved to Done May 20, 2021
@janiversen
Copy link
Member

thanks.

@epenet
Copy link
Contributor Author

epenet commented May 20, 2021 •
edited

Thank you

@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2021
@epenet epenet deleted the ds2405 branch September 6, 2021 06:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: onewire new-feature small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DS2405 not supported
3 participants
@epenet @janiversen @homeassistant