Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DS2405 to supported onewire devices #17710

Merged
merged 1 commit into from May 20, 2021
Merged

Conversation

epenet
Copy link
Contributor

@epenet epenet commented May 6, 2021

Proposed change

Add DS2405 to supported onewire devices

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 6, 2021
@probot-home-assistant probot-home-assistant bot added the next This PR goes into the next branch label May 6, 2021
@probot-home-assistant probot-home-assistant bot added the has-parent This PR has a parent PR in a other repo label May 6, 2021
@probot-home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.
(message by DocsTargetBranch)

@epenet epenet marked this pull request as ready for review May 6, 2021 06:57
@epenet
Copy link
Contributor Author

epenet commented May 6, 2021

cc @klona

@epenet
Copy link
Contributor Author

epenet commented May 6, 2021

Can we remove needs-rebase label?

@epenet epenet removed their assignment May 6, 2021
@frenck frenck added this to To Do in New documentation via automation May 20, 2021
New documentation automation moved this from To Do to Awaiting Parent PR May 20, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

@frenck frenck merged commit a99cf5a into home-assistant:next May 20, 2021
New documentation automation moved this from Awaiting Parent PR to Done May 20, 2021
@probot-home-assistant probot-home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels May 20, 2021
@epenet epenet deleted the ds2405 branch May 20, 2021 15:07
@epenet
Copy link
Contributor Author

epenet commented May 20, 2021

Thanks

@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants