Remove YAML configuration from Somfy MyLink #50359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
breaking-change
has-tests
integration: somfy_mylink
small-pr
bdraco
reviewed
May 9, 2021
| @@ -111,8 +44,6 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry): | |||
| if "result" not in mylink_status: | |||
| raise ConfigEntryNotReady("The Somfy MyLink device returned an empty result") | |||
|
|
|||
| _async_migrate_entity_config(hass, entry, mylink_status) | |||
|
|
|||
| undo_listener = entry.add_update_listener(_async_update_listener) | |||
There was a problem hiding this comment.
We should change this to entry.async_on_unload in a future PR
bdraco
approved these changes
May 9, 2021
frenck
commented
May 9, 2021
MartinHjelmare
approved these changes
May 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The previously deprecated YAML configuration for the Somfy MyLink integration has been removed.
Your configuration has been imported to the UI in the previous releases and can now safely be removed from your YAML configuration files.
Proposed change
Removes YAML configuration/import for the Somfy MyLink integration.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: