Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle incomplete Sonos alarm event payloads #51353

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

jjlawren
Copy link
Contributor

@jjlawren jjlawren commented Jun 1, 2021

Proposed change

Sonos speakers can sometimes send incomplete alarm event payloads. This handles those instances.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob merged commit 9e3ee73 into home-assistant:dev Jun 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2021
@jjlawren jjlawren deleted the sonos_handle_bad_alarm_event branch June 3, 2021 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing key in Sonos alarm event
4 participants