Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lock entity to support locking, unlocking, jammed #51455

Merged
merged 9 commits into from
Jul 20, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 4, 2021

Breaking change

From home-assistant/architecture#332

Proposed change

Docs

The following should be changed in this PR to validate:

The following need to be investigated and merged around the same time in separate PRs

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member Author

bdraco commented Jul 6, 2021

I'll get back to this one after 2021.7 ships as I've been focused on nmap and zeroconf related items

@bdraco
Copy link
Member Author

bdraco commented Jul 10, 2021

Alexa supports jammed as well. Looks like all the voice assistants do

https://developer.amazon.com/en-US/docs/alexa/device-apis/alexa-lockcontroller.html

Out of steam for tonight though. Something for the weekend

@bdraco bdraco marked this pull request as ready for review July 10, 2021 13:19
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 20, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks actually really good!

@frenck frenck merged commit 9b705ad into home-assistant:dev Jul 20, 2021
@bdraco
Copy link
Member Author

bdraco commented Jul 20, 2021

Thanks. Rebased the others

@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core integration: lock smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants