Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfigFlow for here_travel_time #51552

Closed

Conversation

eifinger
Copy link
Contributor

@eifinger eifinger commented Jun 6, 2021

Breaking change

Config flow support has been added to here_travel_time. Existing YAML configuration entries will be imported automatically but should be removed from YAML configuration after import. Import support will be removed in a future release.

Proposed change

  • Add ConfigFlow to here_travel_time.
  • Use DataUpdateCoordinator

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@AMODLT
Copy link

AMODLT commented Jun 6, 2021

Que hago? No entiendo el inglés

@AMODLT
Copy link

AMODLT commented Jun 6, 2021

Gracias

@eifinger eifinger force-pushed the here_travel_time_config_flow branch from a7aea04 to 934b29f Compare June 11, 2021 12:57
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 11, 2021
@eifinger
Copy link
Contributor Author

Still open

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR implements both a config flow and a DataUpdateCoordinator, those need to be split into two separate PRs. Please, make PRs as small as possible.

@eifinger
Copy link
Contributor Author

eifinger commented Nov 14, 2021

@frenck yes is does. And I do understand that this seems to increase the review burden. But I am convinced that the overall complexity is lower that way and faster to implement.

@frenck
Copy link
Member

frenck commented Nov 14, 2021

I don't agree, it is in general why PRs linger around so long, as no one wants to review it.
Neither do I, hence me asking to make small iterative changes instead.

Besides, it is against our contribution standards. Please split it.

Thanks 👍

@eifinger eifinger closed this Nov 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants