-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConfigFlow for here_travel_time #51552
Add ConfigFlow for here_travel_time #51552
Conversation
31053ed
to
7bcd202
Compare
Que hago? No entiendo el inglés |
Gracias |
a7aea04
to
934b29f
Compare
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Still open |
934b29f
to
2038c0e
Compare
5b6689a
to
7b60c66
Compare
312e9db
to
cb4d7be
Compare
5f2b7bf
to
6a4b035
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR implements both a config flow and a DataUpdateCoordinator, those need to be split into two separate PRs. Please, make PRs as small as possible.
@frenck yes is does. And I do understand that this seems to increase the review burden. But I am convinced that the overall complexity is lower that way and faster to implement. |
I don't agree, it is in general why PRs linger around so long, as no one wants to review it. Besides, it is against our contribution standards. Please split it. Thanks 👍 |
Breaking change
Config flow support has been added to
here_travel_time
. Existing YAML configuration entries will be imported automatically but should be removed from YAML configuration after import. Import support will be removed in a future release.Proposed change
DataUpdateCoordinator
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: