Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add httpcore with version 0.13.3 #51799

Merged
merged 2 commits into from Jun 13, 2021
Merged

Add httpcore with version 0.13.3 #51799

merged 2 commits into from Jun 13, 2021

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Jun 13, 2021

Breaking change

Proposed change

httpcore is a dependency of httpx, 0.13.4 of it was released on June 9 https://github.com/encode/httpcore/releases/tag/0.13.4
This has broken several integrations.

This PR adds httpcore==0.13.3 to the package_constrains.txt file.

Fixes #51778, fixes #51780, fixes #51798, fixes #51781

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@ludeeus ludeeus added this to the 2021.6.5 milestone Jun 13, 2021
@project-bot project-bot bot added this to Needs review in Dev Jun 13, 2021
Dev automation moved this from Needs review to Reviewer approved Jun 13, 2021
@frenck frenck merged commit 33ac4db into dev Jun 13, 2021
Dev automation moved this from Reviewer approved to Done Jun 13, 2021
@frenck frenck deleted the httpcore-constrain branch June 13, 2021 08:21
@muhlba91
Copy link

is there any eta when we can expect this to hit the release? :)

@jouster1974
Copy link

another confirmation that PVoutput has stopped working...will keep an eye on the next release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
6 participants