Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use attrs instead of properties in Bravia TV integration #52045

Merged
merged 7 commits into from Jun 23, 2021
Merged

Use attrs instead of properties in Bravia TV integration #52045

merged 7 commits into from Jun 23, 2021

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Jun 21, 2021

Breaking change

Proposed change

Use _attr if possible.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Drafteed, mind taking a look at this pull request as its been labeled with an integration (braviatv) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Comment on lines 140 to 142
if self.coordinator.volume is not None:
return self.coordinator.volume / 100
return None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can move this to _refresh_volume in the coordinator and store already calculated volume.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

homeassistant/components/braviatv/media_player.py Outdated Show resolved Hide resolved
@bieniu
Copy link
Member Author

bieniu commented Jun 23, 2021

I found that attrs can only be used for static data. source, source_list, is_on, etc. stored in the attrs don't update properly.
I also removed variables self.channel_number and self.program_media_type as they are not used.

@Drafteed
Copy link
Contributor

Drafteed commented Jun 23, 2021

I also removed variables self.channel_number and self.program_media_type as they are not used.

Uh :) I was planning to use them to add support for play_media & media_content_type=channel support (like this). This service is used by Google and Yandex voice assistants.

@bieniu
Copy link
Member Author

bieniu commented Jun 23, 2021

I was planning to use them

Ops, I'll revert them 馃槉

Copy link
Contributor

@Drafteed Drafteed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tested and everything is ok.
P.S. I think we can deprecate YAML configuration.

@bieniu
Copy link
Member Author

bieniu commented Jun 23, 2021

I think we can deprecate YAML configuration

I want to remove importing YAML config in next PR.

Dev automation moved this from Needs review to Reviewer approved Jun 23, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bieniu 馃憤

@frenck frenck merged commit 75faee4 into home-assistant:dev Jun 23, 2021
Dev automation moved this from Reviewer approved to Done Jun 23, 2021
@bieniu bieniu deleted the bravia-attrs branch June 23, 2021 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants