Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsusWRT load average sensors #52230

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

ollo69
Copy link
Contributor

@ollo69 ollo69 commented Jun 27, 2021

Proposed change

Additional load average sensors based on available API method.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @kennedyshead, mind taking a look at this pull request as its been labeled with an integration (asuswrt) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@kennedyshead
Copy link
Contributor

👍

homeassistant/components/asuswrt/sensor.py Outdated Show resolved Hide resolved
tests/components/asuswrt/test_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/asuswrt/router.py Outdated Show resolved Hide resolved
homeassistant/components/asuswrt/sensor.py Show resolved Hide resolved
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ollo69 👍

@frenck frenck merged commit c6efded into home-assistant:dev Jun 28, 2021
@ollo69
Copy link
Contributor Author

ollo69 commented Jun 28, 2021

Think that this should require doc update, doesn't it?

@frenck
Copy link
Member

frenck commented Jun 28, 2021

@ollo69 Oh right! Sorry, I was under the impression this integration didn't list the specific sensors. Yes, please :)

@ollo69 ollo69 deleted the asuswrt-loadavg-sensor branch June 28, 2021 21:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants