Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MODBUS connection type rtuovertcp does not connect #52505

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Fix MODBUS connection type rtuovertcp does not connect #52505

merged 2 commits into from
Jul 5, 2021

Conversation

janiversen
Copy link
Member

Breaking change

Proposed change

Wrong assignment.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Please include in first upcoming beta.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@thecode thecode changed the title Solve #52495 (2021.7.0b0) Fix MODBUS connection type rtuovertcp does not connect Jul 4, 2021
@thecode thecode added this to the 2021.7.0 milestone Jul 4, 2021
frenck
frenck approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @janiversen 👍

@frenck frenck merged commit 1cb2989 into home-assistant:dev Jul 5, 2021
frenck pushed a commit that referenced this pull request Jul 5, 2021
@janiversen @frenck
Fix MODBUS connection type rtuovertcp does not connect (#52505)
206437b 
* Correct host -> framer.

* Use function pointer
@janiversen janiversen deleted the issue_52495 branch July 6, 2021 09:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: modbus small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.7.0
Development

Successfully merging this pull request may close these issues.

MODBUS connection type rtuovertcp does not connect [Errno -3].
4 participants
@janiversen @frenck @thecode @homeassistant