Split color temp and color into separate HomeKit services when a light supports both #53471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
force-pushed
the
homekit_light_split_temp
branch
from
e6ed442
to
1ab3c31
Compare
bdraco
changed the title
bdraco
changed the title
bdraco
force-pushed
the
homekit_light_split_temp
branch
from
1ab3c31
to
80ca3a8
Compare
…t supports both - The HomeKit spec does not allow a single service to have both hue/sat and color temp. We avoid the source of truth problem by offering two services depending on the color mode
bdraco
force-pushed
the
homekit_light_split_temp
branch
from
80ca3a8
to
791dc56
Compare
bdraco
changed the title
frenck
added
the
smash
balloob
approved these changes
Jul 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
and color temp. We avoid the source of truth problem by offering two
services depending on the color mode
Fixes #50824
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: