Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state_class measurements in wiffi integration #54279

Merged
merged 3 commits into from
Sep 27, 2021

Conversation

mampfes
Copy link
Contributor

@mampfes mampfes commented Aug 8, 2021

Proposed change

Add support for long-term statistics: add property state_class for measurement entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title add support for state_class measurements in wiffi integration Add state_class measurements in wiffi integration Aug 8, 2021
homeassistant/components/wiffi/sensor.py Outdated Show resolved Hide resolved
like
- amount of rainfall per hour/day
- rainfall hours per day
- sunshine hours per day
Co-authored-by: Greg <greg.diehl.gtd@gmail.com>
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Sep 22, 2021
@Danielhiversen Danielhiversen merged commit e5642a8 into home-assistant:dev Sep 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed integration: wiffi new-feature small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants