Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract smappee switch energy attributes into sensors #54329

Merged
merged 12 commits into from
Aug 20, 2021

Conversation

bsmappee
Copy link
Contributor

@bsmappee bsmappee commented Aug 9, 2021

Breaking change

Extract smappee switch energy attributes into sensors

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bsmappee bsmappee marked this pull request as draft August 9, 2021 12:19
@frenck frenck added the energy Related to energy management label Aug 9, 2021
@pergolafabio
Copy link

hey @bsmappee
the 2 entities, are you also going to change those so we can use them with the new energy ?
total power + total consumption ?

@bsmappee
Copy link
Contributor Author

bsmappee commented Aug 9, 2021

hey @bsmappee
the 2 entities, are you also going to change those so we can use them with the new energy ?
total power + total consumption ?

yes, the PR is still a draft/wip

@pergolafabio
Copy link

hey @bsmappee
the 2 entities, are you also going to change those so we can use them with the new energy ?
total power + total consumption ?

yes, the PR is still a draft/wip

perfect , gonna load it as custom once you are finished to test :)

@balloob
Copy link
Member

balloob commented Aug 9, 2021

Note that you also need to implement last_reset for Home Assistant to be able to track statistics. We might simplify this in the future but for now that's a requirement.

@bsmappee bsmappee marked this pull request as ready for review August 10, 2021 08:23
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a merge conflict that needs to be resolved.

Additionally, we've made new state classes available, which would allow simplifying this PR, as the last_reset can probably be removed. (Be sure to rebase this PR onto the latest dev branch)

Please see: https://developers.home-assistant.io/blog/2021/08/16/state_class_total/

@bsmappee
Copy link
Contributor Author

Merge conflict has been resolved.

last_reset has been removed by making use of the STATE_CLASS_TOTAL_INCREASING state class.

@frenck frenck self-requested a review August 17, 2021 08:03
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 17, 2021
@balloob balloob merged commit 152f799 into home-assistant:dev Aug 20, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments in a new PR. Thanks!

ENERGY_WATT_HOUR,
"solar_today",
None,
DEVICE_CLASS_POWER,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Power sensors should have W or kW as unit. Should this be an energy sensor instead?

https://developers.home-assistant.io/docs/core/entity/sensor#available-device-classes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENERGY_WATT_HOUR,
"solar_current_hour",
None,
DEVICE_CLASS_POWER,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change by-code-owner cla-signed energy Related to energy management integration: smappee small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants