-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract smappee switch energy attributes into sensors #54329
Conversation
hey @bsmappee |
yes, the PR is still a draft/wip |
perfect , gonna load it as custom once you are finished to test :) |
Note that you also need to implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has a merge conflict that needs to be resolved.
Additionally, we've made new state classes available, which would allow simplifying this PR, as the last_reset can probably be removed. (Be sure to rebase this PR onto the latest dev
branch)
Please see: https://developers.home-assistant.io/blog/2021/08/16/state_class_total/
Merge conflict has been resolved.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments in a new PR. Thanks!
ENERGY_WATT_HOUR, | ||
"solar_today", | ||
None, | ||
DEVICE_CLASS_POWER, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Power sensors should have W or kW as unit. Should this be an energy sensor instead?
https://developers.home-assistant.io/docs/core/entity/sensor#available-device-classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ENERGY_WATT_HOUR, | ||
"solar_current_hour", | ||
None, | ||
DEVICE_CLASS_POWER, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
Breaking change
Extract smappee switch energy attributes into sensors
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: