Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to bump MyQ to 3.1.2 #54488

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Conversation

ehendrix23
Copy link
Contributor

@ehendrix23 ehendrix23 commented Aug 11, 2021

Proposed change

Update pymyq to 3.1.2. Fixes a number of issues including warnings of unknown devices, potential race condition when issuing commands, and an issue with updating device states. Improves connectivity stability

Release notes: https://github.com/arraylabs/pymyq/releases/tag/v3.1.2
Compare view: https://github.com/arraylabs/pymyq/compare/v3.0.4..v3.1.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (myq) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 11, 2021
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add cover.py to .coveragerc or add tests for the new behavior. Good to merge once done.

@bdraco
Copy link
Member

bdraco commented Aug 11, 2021

Seeing this, but I may have just restarted too many times and need to wait.

Screen_Shot_2021-08-11_at_2_51_26_PM

@ehendrix23
Copy link
Contributor Author

Seeing this, but I may have just restarted too many times and need to wait.

Screen_Shot_2021-08-11_at_2_51_26_PM

Just included that error code (104) in pymyq for then resetting the user agent. I had the same issue with error code 54 and after including that to then set/reset the user agent it worked. Seems to be a bit depending on the server one hits I think.
Bumped it to 3.1.2 for this

@ehendrix23 ehendrix23 changed the title Updates to bump MyQ to 3.1.1 Updates to bump MyQ to 3.1.2 Aug 11, 2021
@ehendrix23 ehendrix23 requested a review from bdraco August 11, 2021 21:06
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. All good.

We have been seeing a few issues come in for MyQ lately, so I'll take this for the next patch release since it seems more reliable now.

@bdraco bdraco added this to the 2021.8.7 milestone Aug 11, 2021
@bdraco
Copy link
Member

bdraco commented Aug 12, 2021

Been stable through a few reboots and testing 👍

@bdraco bdraco merged commit c040be4 into home-assistant:dev Aug 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
@ehendrix23 ehendrix23 deleted the Bump_MyQ_to_3.1.1 branch August 16, 2021 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked cla-signed dependency integration: myq small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants