-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to bump MyQ to 3.1.2 #54488
Updates to bump MyQ to 3.1.2 #54488
Conversation
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add cover.py
to .coveragerc
or add tests for the new behavior. Good to merge once done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. All good.
We have been seeing a few issues come in for MyQ lately, so I'll take this for the next patch release since it seems more reliable now.
Been stable through a few reboots and testing 👍 |
Proposed change
Update pymyq to 3.1.2. Fixes a number of issues including warnings of unknown devices, potential race condition when issuing commands, and an issue with updating device states. Improves connectivity stability
Release notes: https://github.com/arraylabs/pymyq/releases/tag/v3.1.2
Compare view: https://github.com/arraylabs/pymyq/compare/v3.0.4..v3.1.2
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: