-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove last_reset attribute from FritzBoxEnergySensor #54644
Remove last_reset attribute from FritzBoxEnergySensor #54644
Conversation
Hey there @mib1185, mind taking a look at this pull request as it has been labeled with an integration ( |
@mib1185 With |
Your tests still think that the last_reset property is set. |
I'm not sure, if I get your question correct, but this sensor should always return the total used energy, since there are only smart plug devices available, which measures the used energy of connected devices. |
change it self looks good, but you still need to adopt the test, so that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
Proposed change
Remove last_reset attribute from
FritzBoxEnergySensor
and set device class toSTATE_CLASS_TOTAL_INCREASING
There are two options for sensors representing meters such as energy meters, where the sensor itself doesn't have a
last_reset
available:STATE_CLASS_TOTAL_INCREASING
With STATE_CLASS_TOTAL_INCREASING, a new meter cycle will be detected if the value of the sensor's value decreases. This should be correct if the sensor only counts used (or delivered) energy, but not both in a single sensor, i.e. the sensor's value can't be decreased. Things will then work as expected if the sensor is for some reason reset to 0, for example after a firmware upgrade or factory reset.
STATE_CLASS_TOTAL
With STATE_CLASS_TOTAL, a new meter cycle will never be detected, and the statistics won't be correct if the sensor is reset.
This PR sets the device class to
STATE_CLASS_TOTAL_INCREASING
Background in #54523
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: