Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Tractive sensors #55170

Merged
merged 16 commits into from
Dec 1, 2021
Merged

Add more Tractive sensors #55170

merged 16 commits into from
Dec 1, 2021

Conversation

Danielhiversen
Copy link
Member

Breaking change

Proposed change

Tractive, add more sensors

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @zhulik, @bieniu, mind taking a look at this pull request as it has been labeled with an integration (tractive) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Copy link
Member

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Danielhiversen Danielhiversen added the smash Indicator this PR is close to finish for merging or closing label Aug 28, 2021
@MartinHjelmare MartinHjelmare changed the title Tractive, add more sensors Add more Tractive sensors Sep 1, 2021
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Copy link
Member

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine now. Sorry for reversing the order on the review (approval first, then comments). I think I was completely blind when I first looked at this change 😉

@Danielhiversen
Copy link
Member Author

Anyway, thanks for the review 👍

@bieniu
Copy link
Member

bieniu commented Sep 24, 2021

@Danielhiversen Could you rebase?

@Danielhiversen
Copy link
Member Author

Done. Should we merge it?

@bieniu
Copy link
Member

bieniu commented Sep 24, 2021

I asked on members group on Discord to have someone take a look.

@Danielhiversen Danielhiversen removed the smash Indicator this PR is close to finish for merging or closing label Sep 25, 2021
@Danielhiversen Danielhiversen marked this pull request as draft September 27, 2021 05:18
Danielhiversen and others added 3 commits October 8, 2021 11:38
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
@Danielhiversen Danielhiversen marked this pull request as ready for review October 8, 2021 09:55
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
@bieniu bieniu added the smash Indicator this PR is close to finish for merging or closing label Oct 16, 2021
@bieniu bieniu requested a review from balloob November 24, 2021 20:21
@Danielhiversen
Copy link
Member Author

@bieniu Should we merge this?

@bieniu
Copy link
Member

bieniu commented Dec 1, 2021

I think so 👍

@Danielhiversen Danielhiversen merged commit fbaec76 into dev Dec 1, 2021
@Danielhiversen Danielhiversen deleted the tractive_sensors branch December 1, 2021 19:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed integration: tractive new-feature smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants