Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate mypy for sonar #55327

Merged
merged 5 commits into from
Aug 28, 2021
Merged

Activate mypy for sonar #55327

merged 5 commits into from
Aug 28, 2021

Conversation

janiversen
Copy link
Member

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @ctalkington, mind taking a look at this pull request as it has been labeled with an integration (sonarr) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@ctalkington ctalkington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting on reauth fix. #55329

@janiversen
Copy link
Member Author

Would be nice to refer to the PR.

@janiversen janiversen marked this pull request as draft August 27, 2021 12:59
@janiversen janiversen marked this pull request as ready for review August 27, 2021 19:01
@janiversen
Copy link
Member Author

@ctalkington @MartinHjelmare with #55329 merged, I have rebased/corrected this PR.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid using Any as far as possible. Check the sonarr library for the correct types.

homeassistant/components/sonarr/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/sonarr/sensor.py Outdated Show resolved Hide resolved
janiversen and others added 2 commits August 28, 2021 10:35
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janiversen janiversen merged commit d1965ee into home-assistant:dev Aug 28, 2021
@janiversen janiversen deleted the mypy_sonarr branch August 28, 2021 10:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants