Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in in rfxtrx Barometer sensor #55839

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Fix typo in in rfxtrx Barometer sensor #55839

merged 1 commit into from
Sep 6, 2021

Conversation

mrwhite31
Copy link
Contributor

@mrwhite31 mrwhite31 commented Sep 6, 2021

Fix typo in sensor.py to fix barometer unavailability.

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Fix typo in sensor.py to fix barometer unavailability
@homeassistant
Copy link
Contributor

Hi @mrwhite31,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @Danielhiversen, @elupus, @RobBie1221, mind taking a look at this pull request as it has been labeled with an integration (rfxtrx) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ludeeus ludeeus added this to the 2021.9.4 milestone Sep 6, 2021
Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ludeeus ludeeus changed the title Fix typo in sensor.py Barometer Fix typo in in rfxtrx Barometer sensor Sep 6, 2021
@ludeeus ludeeus merged commit e6a29b6 into home-assistant:dev Sep 6, 2021
balloob pushed a commit that referenced this pull request Sep 6, 2021
Fix typo in sensor.py to fix barometer unavailability
@balloob balloob mentioned this pull request Sep 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants