Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zwave_js/node_state WS API command #55979

Merged
merged 4 commits into from
Sep 9, 2021

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Sep 8, 2021

Proposed change

As I was looking into an issue around values getting after the fact, I realized that when we get value updates, we update the Value instance data and not the Node instance data that includes a list of values when we initially loaded the node. This means that the raw node state is not accurate, and we need to combine the raw node state with the value state to get the real state of a node. This is only a problem when we get node state and not a full state dump because with the former, we are using the lib as the source, whereas with the latter we use the driver/server.

This is a bugfix but this API command is not in use yet so it can wait for the next release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

tests/components/zwave_js/test_api.py Outdated Show resolved Hide resolved
tests/components/zwave_js/test_api.py Outdated Show resolved Hide resolved
raman325 and others added 2 commits September 8, 2021 16:11
Co-authored-by: jan iversen <jancasacondor@gmail.com>
Copy link
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think about improving the library so that we don't have stale data that can be used by mistake.

@raman325
Copy link
Contributor Author

raman325 commented Sep 9, 2021

We should think about improving the library so that we don't have stale data that can be used by mistake.

Yeah that's on my list of items to fix. I think this is the only area where that is a problem 🤞🏾

@raman325 raman325 merged commit 113288c into home-assistant:dev Sep 9, 2021
@raman325 raman325 deleted the node_state branch September 9, 2021 18:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants