-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zwave_js/node_state WS API command #55979
Conversation
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( |
Co-authored-by: jan iversen <jancasacondor@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should think about improving the library so that we don't have stale data that can be used by mistake.
Yeah that's on my list of items to fix. I think this is the only area where that is a problem 🤞🏾 |
Proposed change
As I was looking into an issue around values getting after the fact, I realized that when we get value updates, we update the
Value
instance data and not theNode
instance data that includes a list of values when we initially loaded the node. This means that the raw node state is not accurate, and we need to combine the raw node state with the value state to get the real state of a node. This is only a problem when we get node state and not a full state dump because with the former, we are using the lib as the source, whereas with the latter we use the driver/server.This is a bugfix but this API command is not in use yet so it can wait for the next release.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: