Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Escea fireplace integration #56039

Merged
merged 53 commits into from
Aug 8, 2022

Conversation

lazdavila
Copy link

@lazdavila lazdavila commented Sep 10, 2021

Proposed change

Adds a new climate integration for Escea fireplaces.
This is a local push implementation, using UDP for discovery and communicating with fireplaces.
Also created and added a new dependency https://pypi.org/project/pescea/ to manage the device interface.
The code was based on the iZone climate integration (which uses UDP for discovery, but that uses http for controller).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @lazdavila,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@lazdavila lazdavila changed the title Escea integration Add Escea fireplace integration Sep 11, 2021
@lazdavila lazdavila marked this pull request as ready for review September 11, 2021 01:21
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A brief initial code review, see the comments inline.

homeassistant/components/escea/climate.py Outdated Show resolved Hide resolved
homeassistant/components/escea/climate.py Outdated Show resolved Hide resolved
homeassistant/components/escea/climate.py Outdated Show resolved Hide resolved
homeassistant/components/escea/climate.py Outdated Show resolved Hide resolved
homeassistant/components/escea/translations/bg.json Outdated Show resolved Hide resolved
homeassistant/components/escea/climate.py Outdated Show resolved Hide resolved
homeassistant/components/escea/climate.py Outdated Show resolved Hide resolved
homeassistant/components/escea/climate.py Outdated Show resolved Hide resolved
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the yaml configuration as discussed on discord has been taken care off! 👍 Let's hope someone else will do another review round pre-merge :-)

homeassistant/components/escea/discovery.py Outdated Show resolved Hide resolved
homeassistant/components/escea/discovery.py Outdated Show resolved Hide resolved
homeassistant/components/escea/discovery.py Outdated Show resolved Hide resolved
homeassistant/components/escea/discovery.py Outdated Show resolved Hide resolved
homeassistant/components/escea/discovery.py Outdated Show resolved Hide resolved
homeassistant/components/escea/climate.py Outdated Show resolved Hide resolved
homeassistant/components/escea/climate.py Outdated Show resolved Hide resolved
homeassistant/components/escea/climate.py Outdated Show resolved Hide resolved
homeassistant/components/escea/config_flow.py Outdated Show resolved Hide resolved
tests/components/escea/test_config_flow.py Outdated Show resolved Hide resolved
lazdavila and others added 15 commits August 5, 2022 08:30
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@MartinHjelmare MartinHjelmare self-assigned this Aug 7, 2022
@MartinHjelmare MartinHjelmare removed their assignment Aug 7, 2022
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit a1d5a4b into home-assistant:dev Aug 8, 2022
@lazdavila lazdavila deleted the escea_integration branch August 8, 2022 10:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants