-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override the jinja2 int filter #57470
Conversation
Should we make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
For consistency that sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{ "1.1" | int }}
Returns 1
now (in this PR).
However, in the logs:
{{ "1.1" | int }}' but no default was specified. Currently 'int' will return '0', however this template will fail to render in Home Assistant core 2021.12
While correct on missing default, it doesn't return 0
...
Additionally, I think this will be dropped in 2022.1 and not 2021.12? (2 cycles deprecation?)
As discussed, my issues were incorrect, as I had multiple lines in the dev tools at the same time. I attributed the error message to the wrong occurrence/template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @emontnemery 👍
Proposed change
Override the jinja2 int filter to log a warning if the conversion fails and no default value has been specified.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: