Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the jinja2 int filter #57470

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Override the jinja2 int filter #57470

merged 3 commits into from
Oct 11, 2021

Conversation

emontnemery
Copy link
Contributor

Proposed change

Override the jinja2 int filter to log a warning if the conversion fails and no default value has been specified.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@emontnemery
Copy link
Contributor Author

Should we make int available also as a function, similar to float?

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Member

Should we make int available also as a function, similar to float?

For consistency that sounds good.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{ "1.1" | int }}

Returns 1 now (in this PR).

However, in the logs:

{{ "1.1" | int }}' but no default was specified. Currently 'int' will return '0', however this template will fail to render in Home Assistant core 2021.12

While correct on missing default, it doesn't return 0...

Additionally, I think this will be dropped in 2022.1 and not 2021.12? (2 cycles deprecation?)

@frenck
Copy link
Member

frenck commented Oct 11, 2021

As discussed, my issues were incorrect, as I had multiple lines in the dev tools at the same time. I attributed the error message to the wrong occurrence/template.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @emontnemery 👍

@frenck frenck merged commit 7acb1b6 into dev Oct 11, 2021
@frenck frenck deleted the template_override_int_filter branch October 11, 2021 22:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template defaults: int should behave the same way as float
4 participants