-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vlc telnet config flow #57513
Add vlc telnet config flow #57513
Conversation
Hey there @rodripf, @dmcc, mind taking a look at this pull request as it has been labeled with an integration ( |
except (ConnErr, EOFError) as err: | ||
except CommandError as err: | ||
LOGGER.error("Command error: %s", err) | ||
except ConnectError as err: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a follow up, I'm planning to add a decorator to catch these errors in all entity methods that do client calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local tested
- migrate YAML configuration ✔️
- after migration media player still useable ✔️
- re-auth (by removing and re-adding VLC addon) ✔️
- manually adding integration ✔️
Breaking change
The VLC media player Telnet integration migrated to configuration via the UI. Configuring VLC media player Telnet via YAML configuration has been deprecated and will be removed in a future Home Assistant release.
Your existing YAML configuration is automatically imported on upgrade to this release; and thus can be safely removed from your YAML configuration after upgrading.
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: