New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exclude option to default_config #57871
Conversation
This is a long-requested enhancement. Lots of feedback (and votes) here: |
Very usefull indeed! |
5e91761
to
17c9059
Compare
17c9059
to
1b2c49f
Compare
What's delaying this? Anything that can be done? |
Unfortunately I got stuck, I'll briefly explain why below. Because of that and due to a lack of time I'm afraid I'll have to close this PR for now. Also, this is not required anymore for the DHCP integration, as the issue with spamming has been fixed in the integration itself. The issue is as follows: this is fully working as is. But there's a catch: the original code cleverly used the
I haven't looked into the core very long, so I could be wrong. If so, please correct me! 馃槃 Hopefully I can find some time to work on this soon. But if someone else wants to take over: be my guest! |
Why not just make the dependencies in /homeassistant/components/default_config/manifest.json selectable? I believe that is where the default config entry is defined. |
Proposed change
The
default_config
integration enables a set of default integrations. Each integration in this set can still be configured by the user by simply adding it afterdefault_config
. For example:So while it's still possible to change configuration for each default integration, it's currently not possible to disable any of the default integrations.
This could be useful, for example I'm having an issue with the
dhcp
integration in Docker. I don't need it. But to disable it now, I must remove thedefault_config
integration and keep track of all the default integrations myself. I've done this in the past, and it resulted in me missing out on a lot of new features in new Home Assistant releases. 馃槃I'm creating this PR to get some feedback. I'll add docs & tests if you like my suggestion!
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: