Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue parsing color effect None in flux_led #57979

Merged
merged 4 commits into from
Oct 19, 2021

Conversation

brianegge
Copy link
Contributor

@brianegge brianegge commented Oct 18, 2021

Proposed change

Fix import of yaml config when there is no custom effect

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @icemanch, mind taking a look at this pull request as it has been labeled with an integration (flux_led) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck changed the title Fix issue parsing color effect None, update manifest for 0x21 models Fix issue parsing color effect None, update manifest for 0x21 models in flux_led Oct 18, 2021
@bdraco bdraco changed the title Fix issue parsing color effect None, update manifest for 0x21 models in flux_led Fix issue parsing color effect None Oct 18, 2021
@bdraco bdraco changed the title Fix issue parsing color effect None Fix issue parsing color effect None in flux_led Oct 18, 2021
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Small suggestion above to avoid the problem from happening in the import

@bdraco bdraco self-requested a review October 19, 2021 02:29
@bdraco
Copy link
Member

bdraco commented Oct 19, 2021

Thanks for noticing this and fixing before we released 👍

@bdraco bdraco merged commit 708f2ae into home-assistant:dev Oct 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants