Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NamedTuple in Vallox service_to_method mapping #58361

Merged

Conversation

andre-richter
Copy link
Contributor

Implementation for Vallox part of @cdce8p' original PR: #55756

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Oct 24, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 24, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 25, 2021
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andre-richter 馃憤

Dev automation moved this from By Code Owner to Reviewer approved Oct 26, 2021
@emontnemery emontnemery merged commit 486866b into home-assistant:dev Oct 26, 2021
Dev automation moved this from Reviewer approved to Done Oct 26, 2021
Djelibeybi pushed a commit to Djelibeybi/home-assistant-core that referenced this pull request Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2021
@andre-richter andre-richter deleted the vallox_service_named_tuple branch December 28, 2021 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants