Adjust onewire device model #58516
Merged
Adjust onewire device model #58516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
code-quality
has-tests
integration: onewire
small-pr
|
Hey there @garbled1, mind taking a look at this pull request as it has been labeled with an integration ( |
frenck
added
smash
|
There is a merge conflict. |
|
@frenck rebased on latest |
frenck
added
the
smash
|
no objections |
bdraco
reviewed
Oct 27, 2021
| if TYPE_CHECKING: | ||
| assert self.owproxy | ||
| device_type = self.owproxy.read(f"{device_path}type").decode() | ||
| _LOGGER.debug("read `%stype`: %s", device_path, device_type) |
There was a problem hiding this comment.
Suggested change
| _LOGGER.debug("read `%stype`: %s", device_path, device_type) | |
| _LOGGER.debug("read `%stype`: %s", device_path, device_type) |
I'm not sure we need the logging, but it was existing.
There was a problem hiding this comment.
Hi @bdraco this was to facilitate pytest debugging.
I had issues injecting just the right amount of side_effect, in the right order, etc...
I can remove if you think it's better to clean it up.
There was a problem hiding this comment.
Its probably fine to leave in as it doesn't look like its called too frequently.
|
Thanks @bdraco |
natekspencer
pushed a commit
to natekspencer/home-assistant-core
that referenced
this pull request
Oct 29, 2021
Co-authored-by: epenet <epenet@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adjust onewire device model
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: