Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix air pressure unit of measurement in Luftdaten #59687

Merged

Conversation

muggenhor
Copy link

…ascal

Proposed change

The air pressure numbers reported over the Luftdaten API are expressed in pascal but were previously interpreted as hecto pascal. With this fix it no longer looks like we're on a gas giant.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

I cannot run tests because tox fails to install pkgs due to versioning conflicts in the requirements txt files.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @GielVanSchijndel-TomTom,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added bugfix integration: luftdaten merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines. labels Nov 14, 2021
@probot-home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (luftdaten) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet
Copy link
Contributor

epenet commented Nov 14, 2021

Please adjust the PR to target "dev" not "master"

@muggenhor muggenhor force-pushed the fix/luftdaten-air-pressure-unit branch from d99617d to f372c1c Compare November 14, 2021 20:27
@homeassistant
Copy link
Contributor

Hi @muggenhor,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@muggenhor muggenhor force-pushed the fix/luftdaten-air-pressure-unit branch from f372c1c to 8c6cd45 Compare November 14, 2021 20:29
@muggenhor muggenhor changed the base branch from master to dev November 14, 2021 20:29
@muggenhor
Copy link
Author

Please adjust the PR to target "dev" not "master"

I had to rebase it to be able to do that (this was based off tag 2021.11.3).

@frenck frenck changed the title fix(luftdaten): air pressure is reported in Pascal instead of Hecto Pascal Fix air pressure unit of measurement in Luftdaten Nov 14, 2021
@frenck frenck removed the merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`. label Nov 14, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @muggenhor 👍

@frenck frenck merged commit 04a258b into home-assistant:dev Nov 15, 2021
@muggenhor muggenhor deleted the fix/luftdaten-air-pressure-unit branch November 15, 2021 15:01
natekspencer pushed a commit to natekspencer/home-assistant-core that referenced this pull request Nov 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants