-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix air pressure unit of measurement in Luftdaten #59687
Fix air pressure unit of measurement in Luftdaten #59687
Conversation
It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration ( |
Please adjust the PR to target "dev" not "master" |
d99617d
to
f372c1c
Compare
Hi @muggenhor, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
f372c1c
to
8c6cd45
Compare
I had to rebase it to be able to do that (this was based off tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @muggenhor 👍
…ascal
Proposed change
The air pressure numbers reported over the Luftdaten API are expressed in pascal but were previously interpreted as hecto pascal. With this fix it no longer looks like we're on a gas giant.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)I cannot run tests because tox fails to install pkgs due to versioning conflicts in the requirements txt files.
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: