-
-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dataclass for ZeroconfServiceInfo #60206
Conversation
dbb88f9
to
2007658
Compare
Will need another rebase as #60221 wasn't merged yet |
2007658
to
8b31b78
Compare
I dismissed the review request since this is back to being a draft so it can be requested again later |
This is ready for review again. All the failing tests now pass on my machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @epenet 馃憤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 馃憤
Breaking change
Zeroconf discovery now uses a dataclass instead of a dictionary object.
Access using
__getitem__
will fail in version 2022.6.Please use
<cls>.<name>
instead.Proposed change
Zeroconf discovery now uses a dataclass instead of a dictionary object.
Access using
__getitem__
will fail in version 2022.6.Please use
<cls>.<name>
instead.Linked to this comment in the architecture discussion home-assistant/architecture#662 (comment)
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: