Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dataclass for ZeroconfServiceInfo #60206

Merged
merged 10 commits into from
Nov 23, 2021

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Nov 23, 2021

Breaking change

Zeroconf discovery now uses a dataclass instead of a dictionary object.
Access using __getitem__ will fail in version 2022.6.
Please use <cls>.<name> instead.

Proposed change

Zeroconf discovery now uses a dataclass instead of a dictionary object.
Access using __getitem__ will fail in version 2022.6.
Please use <cls>.<name> instead.

Linked to this comment in the architecture discussion home-assistant/architecture#662 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Nov 23, 2021

Will need another rebase as #60221 wasn't merged yet

@bdraco
Copy link
Member

bdraco commented Nov 23, 2021

I dismissed the review request since this is back to being a draft so it can be requested again later

@epenet epenet marked this pull request as ready for review November 23, 2021 21:25
@epenet epenet requested a review from frenck as a code owner November 23, 2021 21:25
@epenet
Copy link
Contributor Author

epenet commented Nov 23, 2021

This is ready for review again. All the failing tests now pass on my machine.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @epenet 馃憤

Dev automation moved this from Needs review to Reviewer approved Nov 23, 2021
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@frenck frenck merged commit 44611d7 into home-assistant:dev Nov 23, 2021
Dev automation moved this from Reviewer approved to Done Nov 23, 2021
@epenet epenet deleted the zeroconf-dataclass branch November 23, 2021 22:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants