-
-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ZeroconfServiceInfo in tests (g-m) #60217
Conversation
Hey there @wonderslug, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @vangorra, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @swails, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @Jc2k, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @balloob, @frenck, @marcelveldt, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have probably set port to something like 8080, but if None
is a permitted value than i'm fine with this too. LGTM.
Proposed change
As preliminary work for #60206, ensure that all properties in
ZeroconfServiceInfo
are initialised in testsType of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: