Add configuration_url to AccuWeather integration #60381
Conversation
probot-home-assistant
bot
added
integration: accuweather
new-feature
small-pr
|
Hey there @bieniu, mind taking a look at this pull request as it has been labeled with an integration ( |
| @@ -73,6 +73,7 @@ def __init__( | |||
| identifiers={(DOMAIN, coordinator.location_key)}, | |||
| manufacturer=MANUFACTURER, | |||
| name=NAME, | |||
| configuration_url="https://www.accuweather.com", | |||
There was a problem hiding this comment.
We should link to the specific location configured, as that information is available. (Deeplink when possible).
There was a problem hiding this comment.
Spent quite some times looking around the API, but unsure how I can get a link to the website - could do with a nudge
There was a problem hiding this comment.
Look at the website, open a location, see how the link is constructed. Use the location_key already available.
There was a problem hiding this comment.
Looks like you can just pass in http://accuweather.com/en/_/_/{location_key}/weather-forecast/{location_key}/ and it'll auto-populate the URL
MartinHjelmare
changed the title
| # You don't need to provide specific details for the URL, | ||
| # so passing in _ characters is fine if the location key | ||
| # is correct | ||
| configuration_url="http://accuweather.com/en/" |
There was a problem hiding this comment.
It's much easier to read if we wrap the string in parentheses. Black will then format the string parts on new lines indented.
Proposed change
Type of change
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: