Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration_url to AccuWeather integration #60381

Merged
merged 4 commits into from Nov 26, 2021
Merged

Add configuration_url to AccuWeather integration #60381

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b12918a
Added configuration_url to AccuWeather integration
mdawsonuk Nov 25, 2021
be73645
AccuWeather goes directly to forecast for provided location rather th…
mdawsonuk Nov 26, 2021
2863887
Fixed formatting on weather.py
mdawsonuk Nov 26, 2021
424b503
Fix black part 2
mdawsonuk Nov 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions homeassistant/components/accuweather/weather.py
View file
Open in desktop
Expand Up @@ -73,6 +73,12 @@ def __init__(
identifiers={(DOMAIN, coordinator.location_key)},
manufacturer=MANUFACTURER,
name=NAME,
# You don't need to provide specific details for the URL,
# so passing in _ characters is fine if the location key
# is correct
configuration_url="http://accuweather.com/en/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's much easier to read if we wrap the string in parentheses. Black will then format the string parts on new lines indented.

f"_/_/{coordinator.location_key}/"
f"weather-forecast/{coordinator.location_key}/",
)

@property
Expand Down