Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Tesla wall connector config flow #60755

Conversation

einarhauks
Copy link
Contributor

Proposed change

Remove config options and simplify the config flow of the Tesla wall connector integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@einarhauks
Copy link
Contributor Author

@MartinHjelmare Please review this pull request, which is still work in progress

I simplified the user config step: e529f30
...and removed the option to configure scan interval: 822a297

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@MartinHjelmare MartinHjelmare changed the title Tesla wall connector refactor config flow Refactor Tesla wall connector config flow Dec 1, 2021
@MartinHjelmare MartinHjelmare merged commit e7f00c2 into home-assistant:dev Dec 1, 2021
@MartinHjelmare
Copy link
Member

MartinHjelmare commented Dec 1, 2021

Sorry, I was a bit quick with the merge. We should remove the stale strings for the options flow from strings.json too.

@einarhauks
Copy link
Contributor Author

Sorry, I was a bit quick with the merge. We should remove the stale strings for the options flow from strings.json too.

Wow... already merged! I was looking for an option to make the pull request Draft but couldn't find it :(

I'll open a new pull request with the rest of the changes.

@einarhauks
Copy link
Contributor Author

Sorry, I was a bit quick with the merge. We should remove the stale strings for the options flow from strings.json too.
See #60774

@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants