Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config panel to recorder #62604

Closed
wants to merge 2 commits into from

Conversation

sanyatuning
Copy link
Contributor

@sanyatuning sanyatuning commented Dec 22, 2021

Breaking change

Not totally braking. Recorder config will be migrated to config entry and further changes will be ignored.

Proposed change

Add configuration screen to recorder integration.
frontend PR: home-assistant/frontend#11002

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (config) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Dec 22, 2021
@sanyatuning sanyatuning marked this pull request as draft December 22, 2021 15:42
@emontnemery
Copy link
Contributor

Could we expose this via an options flow instead of via a custom WS API?

@sanyatuning
Copy link
Contributor Author

Could we expose this via an options flow instead of via a custom WS API?

Is it possible to show an "entities picker" in the options flow?

@sanyatuning sanyatuning marked this pull request as ready for review January 1, 2022 20:27
@sanyatuning sanyatuning changed the title WIP: Add config panel to recorder Add config panel to recorder Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Apr 3, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 3, 2022
@bdraco
Copy link
Member

bdraco commented Apr 3, 2022

Could we expose this via an options flow instead of via a custom WS API?

Is it possible to show an "entities picker" in the options flow?

Take a look at homeassistant.helpers.selector

@github-actions github-actions bot removed the stale label Apr 3, 2022
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 2, 2022
@github-actions github-actions bot closed this Jul 15, 2022
Dev automation moved this from Needs review to Cancelled Jul 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

4 participants